Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval in wait task #728

Closed
FogDong opened this issue Apr 4, 2021 · 8 comments
Closed

Add approval in wait task #728

FogDong opened this issue Apr 4, 2021 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@FogDong
Copy link
Member

FogDong commented Apr 4, 2021

Feature request

Right now we have our wait task to support starting the task after a time, but can we start the task after some specific action like approval?
In my case, there's some situation that the task needs to be approved by the admin before it gets executed. So before the admin approves the step, the task needs to be paused.

Use case

ref tektoncd/pipeline#3796

@FogDong FogDong added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2021
@imjasonh
Copy link
Member

imjasonh commented Apr 6, 2021

As a simple mechanism for implementing approval, you could create a controller that just waits forever for an Approval-type Run (i.e., doesn't reconcile or take any action), and expects some other system to update its status to Done once approval is granted.

That other system could be an HTTP endpoint, an email/SMS/Slack receiver, etc., with permission to update the Run status.

You could also express rejection of approval by setting the status to Failed, track the identity of the approver in the Run status, implement expiring approvals by reintroducing some wait logic from the wait-task, etc.

@FogDong
Copy link
Member Author

FogDong commented Apr 7, 2021

So we don't want to have approval in the wait task, and prefer to let users implement it themselves? 🤔

@ArjunReddyTunga
Copy link

During CI/CD in DevOps Workflow there should be Release Manager Approval workflow. Isn`t a standard in any DevOps CI/CD Pipeline.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2021
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 13, 2021
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerop
Copy link
Member

jerop commented Jun 3, 2022

for anyone looking into this, this custom task be useful: https://github.com/automatiko-io/automatiko-approval-task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants