Update the GitHub Config settings for Generators #596
Conversation
tekton-robot
added
the
size/L
generators/pkg/generator/generate.go
Outdated
| // DOCKER_CONFIG is used for kaniko to detect docker credential | ||
| env := &github.Spec.Steps[0].Env | ||
| *env = append(*env, corev1.EnvVar{ | ||
| Name: "DOCKER_CONFIG", | ||
| Value: "/tekton/home/.docker/", | ||
| }) |
There was a problem hiding this comment.
These look like options that are step specific. I think we should remove these, letting users set them manually in their steps if they want it. What do you think?
There was a problem hiding this comment.
I agree. The reason why I add it here is that when I apply the resources on the cluster, the pipelinerun failed since the DOCKER_CONFIG is required to allow kaniko to detect docker credential.
YolandaDu1997
force-pushed
the
generators-pr
branch
from
dc44a27
to
aed6edb
Compare
|
Done. |
YolandaDu1997
force-pushed
the
generators-pr
branch
from
aed6edb
to
7e223e3
Compare
|
This is looking good to me! Let's squash up the commits? |
This commit is to add more fields to the input Github config settings to help user specify their workflow with more flexibilty. The added fields are 'revision', 'secret', 'branch', 'storage' and 'service account'. Document the input config fields in the README
YolandaDu1997
force-pushed
the
generators-pr
branch
from
8e0defd
to
409d37d
Compare
sure! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
This PR aims to add more fields to the input Github config settings tohelp user specify their workflow with more flexibilty for Tekton Generators.
The changes includes:
branch,storage,secretName,secretKey,serviceAccountNameto theGitHubSpecstructure.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.