-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Tekton Pipeline Python SDK #622
Conversation
Hi @jinchihe. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
585619d
to
5b796bc
Compare
Hey Reviewers, the PR is ready for review now. Thanks. /cc @vdemeester |
@vdemeester Any more comments? I think that's ready. Thanks. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
I think the first should be to merge it in, and we can then take it from there.
If you are part of the tekton org, you may want to add yourself and OWNER to this folder.
/approve
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-experimental-build-tests |
/restest |
I will take a look the CI issue and fix that ASAP . Thanks. |
5b796bc
to
eb3351d
Compare
05c9594
to
697933a
Compare
Seems the CI test is passed now. Thanks! |
697933a
to
295dcdc
Compare
295dcdc
to
b2d88ca
Compare
/lgtm |
Changes
Note the PR is separate from the PR: tektoncd/pipeline#3081 you can get more from there
The PR is going to generate Tekton Pipeline Python SDK. Python SDK is very import for end user.
Design and implements:
tektoncd/pipeline
repo Generate OpenAPI specification and Swagger file pipeline#3081)See details in the generate script: https://github.com/tektoncd/experimental/blob/b0ac9b0e37a3ba850395831582c7a0f32e50b009/sdk/hack/README.md
Examples:
See detailed examples of taskrun here: https://github.com/tektoncd/experimental/blob/7f25f4c46dc6f30548cde7089e1c7c180e482311/sdk/python/examples/taskrun.ipynb
See detailed Readme and related docs in the PR: https://github.com/tektoncd/experimental/blob/7f25f4c46dc6f30548cde7089e1c7c180e482311/sdk/python/README.md
What's the next:
This is a init SDK generation, lots of things need to do, such as make more Client APIs manually, in this PR, I just finish basic apis... Thanks.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.