-
Notifications
You must be signed in to change notification settings - Fork 121
Introduce customized scheduler to resolve issues from tekton #664
Introduce customized scheduler to resolve issues from tekton #664
Conversation
/assign @imjasonh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some code style changes I'd like to make (not use klog
, take advantage of some helpers from knative/pkg
) but I won't block this PR.
Can you also add an OWNERS for this directory so you can lgtm future changes? Probably @jlpettersson too?
3c53bab
to
51dfe52
Compare
…same volume but maybe run on different nodes. This is a draft version, try to introduce `Scheduler framework` to handle the issue, for now we adopt `affinity assistant` but has issue to measure total resource requirements. Details please check issue: tektoncd/pipeline#3052 I think we will enhance it soon based on further discussion, thanks.
51dfe52
to
e8a2227
Compare
@imjasonh could you take a look, thanks |
/lgtm Let's get this merged and talk about next steps. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's a customized scheduler try to resolve parallel tasks depends on same volume but maybe run on different nodes.
This is a draft version, try to introduce
Scheduler framework
to handle the issue, for now we adoptaffinity assistant
but has issue to measure total resource requirements.Details please check issue: tektoncd/pipeline#3052
I think we will enhance it soon based on further discussion, thanks.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.