Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

[CEL] Create cel folder and add OWNERS #691

Merged
merged 1 commit into from
Jan 14, 2021
Merged

[CEL] Create cel folder and add OWNERS #691

merged 1 commit into from
Jan 14, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jan 13, 2021

Changes

Creating a folder for incubating CELRun project which will provide a
Common Expression Language Custom Task, as proposed in tektoncd/community#304
and adding the OWNERS to approve and review contributions to the project

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

/cc @bobcatfish @imjasonh @pritidesai @afrittoli

Creating a folder for incubating CELRun project which will provide a
Common Expression Language Custom Task, as proposed in tektoncd/community#304
and adding the OWNERS to approve and review contributions to the project
@tekton-robot
Copy link

@jerop: GitHub didn't allow me to request PR reviews from the following users: pritidesai.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

Creating a folder for incubating CELRun project which will provide a
Common Expression Language Custom Task, as proposed in tektoncd/community#304
and adding the OWNERS to approve and review contributions to the project

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide
for more details.

/cc @bobcatfish @imjasonh @pritidesai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2021
@pritidesai
Copy link
Member

Thanks @jerop for initiating this.
/lgtm

@tekton-robot
Copy link

@pritidesai: changing LGTM is restricted to collaborators

In response to this:

Thanks @jerop for initiating this.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@tekton-robot tekton-robot merged commit 3b0e998 into tektoncd:master Jan 14, 2021
@jerop jerop changed the title [CELRun] Create cel folder and add OWNERS [CEL] Create cel folder and add OWNERS Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants