Have the wait-task leverage NewRequeueAfter
#780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively new wrapped error in
knative.dev/pkg
, which automagically does theEnqueueAfter
.Had to rework some tests that were mocking
EnqueueAfter
, but the semantics should remain intact.I also dropped the event this emits on successful reconciliation, since that can be a source of problems at scale. Selfishly, this also reduced the amount of tweaking I had to do in the tests, so I figure win-win.
/kind cleanup
/assign @imjasonh
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.