Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkn hub install should check pipeline version and warn if incompatible #36

Open
sm43 opened this issue Jul 13, 2020 · 6 comments
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen

Comments

@sm43
Copy link
Member

sm43 commented Jul 13, 2020

When installing a task using tkn hub minimum pipeline version should be checked with the pipelines version installed in the cluster.
If it is incompatible, the user should be warned

@sm43 sm43 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 5, 2020
@sm43
Copy link
Member Author

sm43 commented Oct 19, 2020

/close
can be addressed once the install command gets in. Whether we want to add apply in tkn-hub is yet to be discussed as we have kubectl for that and tkn also doesn't have that feature.
currently it can be done as tkn-hub get task buildah | kubectl apply -f

@tekton-robot
Copy link

@sm43: Closing this issue.

In response to this:

/close
can be addressed once the install command gets in. Whether we want to add apply in tkn-hub is yet to be discussed as we have kubectl for that and tkn also doesn't have that feature.
currently it can be done as tkn-hub get task buildah | kubectl apply -f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sthaha
Copy link
Member

sthaha commented Oct 19, 2020

/reopen
We would still need a sub-command to validate if the cluster meets the requirement of a resource. e.g. tkn hub validate-install task/foobar/1.0 can validate if the cluster meets the requirements (minPipelineVersion).

@sthaha sthaha reopened this Oct 19, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@vinamra28
Copy link
Member

/remove-lifecycle rotten
/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen
Projects
Status: Todo
Development

No branches or pull requests

4 participants