Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter and Transform for TektonResult #2022

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix filter and Transform for TektonResult #2022

merged 1 commit into from
Feb 22, 2024

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 22, 2024 •
edited by jkandasa
Loading

Filter was changing the reference for Transformer which led to an incorrect manifest (the one without any transformation but only filter) being applied.

Fix #2023

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 22, 2024
khrm
khrm commented Feb 22, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2024
@khrm
Copy link
Contributor Author

khrm commented Feb 22, 2024

/cherry-pick release-v0.70.x

@tekton-robot
Copy link
Contributor

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.70.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.70.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm
Copy link
Contributor Author

khrm commented Feb 22, 2024

/assign @jkandasa

@khrm
Copy link
Contributor Author

khrm commented Feb 22, 2024

/assign @savitaashture

@khrm
Fix filter and Transform for TektonResult
05ff281 
Filter was changing the reference for Transformer which lead
to incorrect manifest (the one without any transformation but
only filter) being applied.
@savitaashture
Copy link
Contributor

savitaashture commented Feb 22, 2024 •
edited
Loading

Verification on Openshift

tekton-results-api-5bfd8b4cc8-trlpd                  1/1     Running   0          89s
tekton-results-postgres-0                            1/1     Running   0          2m46s
tekton-results-watcher-6dfc9d789b-6b27b              1/1     Running   0          89s

@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 22, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@tekton-robot tekton-robot merged commit 12030b0 into tektoncd:main Feb 22, 2024
8 checks passed
@tekton-robot
Copy link
Contributor

@khrm: new pull request created: #2025

In response to this:

/cherry-pick release-v0.70.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Feb 22, 2024
Merged
@khrm khrm deleted the filterRef branch February 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jkandasa jkandasa

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TektonResult installation fails if targerNamespace is different
5 participants
@khrm @tekton-robot @savitaashture @vdemeester @jkandasa