Add ssh url to gitlab triggerbindings #2421
Conversation
tekton-robot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
needs-ok-to-test
|
Hi @sveno1990. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
size/XS
tekton-robot
added
ok-to-test
| @@ -7,6 +7,8 @@ spec: | |||
| params: | |||
| - name: git-repo-url | |||
| value: $(body.project.git_http_url) | |||
| - name: git-repo-ssh-url | |||
There was a problem hiding this comment.
this is correct for the mr event according to https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events
| @@ -34,6 +36,8 @@ spec: | |||
| value: $(body.commits[0].message) | |||
| - name: git-repo-url | |||
| value: $(body.repository.git_http_url) | |||
| - name: git-repo-ssh-url | |||
| value: $(body.project.git_ssh_url) | |||
There was a problem hiding this comment.
this should be body.repository.git_ssh_url according to https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#push-events
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes