Skip to content

Commit

Permalink
Add/cleanup end to end debug info
Browse files Browse the repository at this point in the history
Something has gone wrong with one of the integration tests on my PR and
I don't know what so I'm trying to add more info.

Added Builds to the dumped CRDs, and also moved the step that deploys
the examples is now after the integration tests b/c it produces a lot of
errors in the logs (hahaha...) and makes it harder to debug integration
tests failures.
  • Loading branch information
bobcatfish committed Oct 12, 2018
1 parent 16c56d1 commit 0e2ad98
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
5 changes: 1 addition & 4 deletions test/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function teardown() {

# Called by `fail_test` (provided by `e2e-tests.sh`) to dump info on test failure
function dump_extra_cluster_state() {
for crd in pipelines pipelineruns tasks taskruns resources pipelineparams
for crd in pipelines pipelineruns tasks taskruns resources pipelineparams builds
do
echo ">>> $crd:"
kubectl get $crd -o yaml --all-namespaces
Expand Down Expand Up @@ -75,9 +75,6 @@ set +o xtrace
# Wait for pods to be running in the namespaces we are deploying to
wait_until_pods_running knative-build-pipeline || fail_test "Pipeline CRD did not come up"

# Run the smoke tests for the examples dir to make sure they are valid
./examples/smoke-test.sh || fail_test

# Run the integration tests
go_test_e2e -timeout=20m ./test || fail_test

Expand Down
8 changes: 7 additions & 1 deletion test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ function integration_tests() {
header "Running integration tests"
local options=""
(( EMIT_METRICS )) && options="--emit-metrics"
./test/e2e-tests.sh ${options}
./test/e2e-tests.sh ${options}

# Run the smoke tests for the examples dir to make sure they are valid
# Run these _after_ the integration tests b/c they don't quite work all the way
# and they cause a lot of noise in the logs, making it harder to debug integration
# test failures.
./examples/smoke-test.sh || fail_test
}

main $@

0 comments on commit 0e2ad98

Please sign in to comment.