Skip to content

Commit

Permalink
Skipping the CI secret sauce 🦕
Browse files Browse the repository at this point in the history
This is skipping tests that depends on the build-crd GCP project that
got deleted recently. This will unblock CI while we replace this with
using our own GCP project (or a better way)

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Sep 8, 2021
1 parent bda40ea commit 2673729
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions internal/builder/v1beta1/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package builder
Expand Down
1 change: 1 addition & 0 deletions test/pipelinerun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func TestPipelineRun(t *testing.T) {
name: "service account propagation and pipeline param",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index, namespace), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err)
}
Expand Down
1 change: 1 addition & 0 deletions test/v1alpha1/pipelinerun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func TestPipelineRun(t *testing.T) {
name: "service account propagation and pipeline param",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err)
}
Expand Down

0 comments on commit 2673729

Please sign in to comment.