Fix Wrong Condition Reason When Fails to Stop Sidecars for A Finished…

… TaskRun

Prior to this commit, if a TaskRun fails to stop sidecars, the
failure reason is `TaskRunResolutionFailed` which does not make
sense at all. This commit creates a new reason for StopSideCar
failure, and fix the wrong condition reason.

pkg/apis/pipeline/v1beta1/taskrun_types.go

@@ -188,6 +188,8 @@ const (
  AwaitingTaskRunResults TaskRunReason = "AwaitingTaskRunResults"
  // TaskRunReasonResultLargerThanAllowedLimit is the reason set when one of the results exceeds its maximum allowed limit of 1 KB
  TaskRunReasonResultLargerThanAllowedLimit TaskRunReason = "TaskRunResultLargerThanAllowedLimit"
+ // TaskRunReasonStopSidecarFailed indicates that the sidecar is not properly stopped.
+ TaskRunReasonStopSidecarFailed = "TaskRunStopSidecarFailed"
 )
 
 func (t TaskRunReason) String() string {

pkg/reconciler/taskrun/taskrun.go

@@ -285,7 +285,7 @@ func (c *Reconciler) stopSidecars(ctx context.Context, tr *v1beta1.TaskRun) erro
  return controller.NewPermanentError(err)
  } else if err != nil {
  logger.Errorf("Error stopping sidecars for TaskRun %q: %v", tr.Name, err)
- tr.Status.MarkResourceFailed(podconvert.ReasonFailedResolution, err)
+ tr.Status.MarkResourceFailed(v1beta1.TaskRunReasonStopSidecarFailed, err)
  }
  return nil
 }