Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ${} in favor of $() syntax #1170

Closed
bobcatfish opened this issue Aug 6, 2019 · 1 comment · Fixed by #1311
Closed

Remove ${} in favor of $() syntax #1170

bobcatfish opened this issue Aug 6, 2019 · 1 comment · Fixed by #1311
Milestone
Pipelines 0.7 🐱

Comments

@bobcatfish
Copy link
Collaborator

In #850 we updated Tekton to support both ${somevariable} and $(somevariable) syntax for variable replacement. The goal is to remove the ${} synxtax in favor of $() but in a backward compatible way. This issue is to track completely removing support for ${} in a later release.
@bobcatfish bobcatfish added the maybe-next-milestone For consideration when planning the next milestone label Aug 6, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.7 🐱 milestone Aug 12, 2019
@bobcatfish
Copy link
Collaborator Author

Note that we should also update the catalog when we do this since after this change the catalog would no longer work with HEAD.

@bobcatfish bobcatfish removed the maybe-next-milestone For consideration when planning the next milestone label Sep 6, 2019
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Sep 14, 2019
@bobcatfish
Remove support for ${} syntax 🗑️
ff0e22b 
In tektoncd#850 we decided that to make our syntax more similar to k8s style
syntax, we will use $() for variable substitution instead of ${}. In a
later iteration we may also want to make it so that anything that can be
acesssed as a variable is also available as an env var to the running
container, but that is TBD.

In tektoncd#1172 we added support for the new syntax, $(), and continued support
for ${}, which was released in 0.6. This commit removes support for
${}.

Fixes tektoncd#1170
@bobcatfish bobcatfish mentioned this issue Sep 14, 2019
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Sep 16, 2019
@bobcatfish @tekton-robot
Remove support for ${} syntax 🗑️
1c4d4b2 
In #850 we decided that to make our syntax more similar to k8s style
syntax, we will use $() for variable substitution instead of ${}. In a
later iteration we may also want to make it so that anything that can be
acesssed as a variable is also available as an env var to the running
container, but that is TBD.

In #1172 we added support for the new syntax, $(), and continued support
for ${}, which was released in 0.6. This commit removes support for
${}.

Fixes #1170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pipelines 0.7 🐱
Development

Successfully merging a pull request may close this issue.

Remove support for ${} syntax 🗑️ bobcatfish/pipeline
1 participant
@bobcatfish