Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PullRequestResource resource usage #1275

Closed
hrishin opened this issue Sep 5, 2019 · 5 comments · Fixed by #1276
Closed

PullRequestResource resource usage #1275

hrishin opened this issue Sep 5, 2019 · 5 comments · Fixed by #1276

Comments

@hrishin
Copy link
Member

hrishin commented Sep 5, 2019

Looks like users are not able to understand how to use the PullRequestResource with secrete configuration.
Maybe it's a bit confusing with respect to documentation.
hrishin added a commit to hrishin/tekton-pipeline that referenced this issue Sep 5, 2019
@hrishin
Enhancements for PullRequest Resource docs
74f9931 
It seems like users may not able able to understnad
how to use the `PullRequestResource` with secrete configuration

This patch adds an example TaskRun/Task to demonstrate
how to use the PR Resoucre.

Fixes tektoncd#1275
hrishin added a commit to hrishin/tekton-pipeline that referenced this issue Sep 5, 2019
@hrishin
Enhancements for PullRequest Resource docs
5113212 
It seems like users may not able able to understand
how to use the `PullRequestResource` with secrete configuration

This patch adds an example TaskRun/Task to demonstrate
how to use the PR Resource.

Fixes tektoncd#1275
@hrishin hrishin mentioned this issue Sep 5, 2019
Merged
3 tasks
@vincent-pli
Copy link
Member

@hrishin
Could you supply some example for use PullRequest Resource as output, I means update PR status on Github.

hrishin added a commit to hrishin/tekton-pipeline that referenced this issue Sep 5, 2019
@hrishin
Enhancements for PullRequest Resource docs
aa14485 
It seems like users may not able able to understand
how to use the `PullRequestResource` with secrete configuration

This patch adds an example TaskRun/Task to demonstrate
how to use the PR Resource.

Fixes tektoncd#1275
@hrishin
Copy link
Member Author

hrishin commented Sep 9, 2019 •
edited
Loading

@vincent-pli that sounds nice idea. Just wondering where shall we add the example?
Because example Task has to pass the CI integration and not sure how to keep the Github creds.

@sbwsg ^

@hrishin
Copy link
Member Author

hrishin commented Sep 11, 2019

A better way we can address it in the followup PR? @vincent-pli @sbwsg

@ghost
Copy link

ghost commented Sep 11, 2019

If a working example is required I'd personally tackle it in a separate PR from #1276. Seems like it's going to need more thought on how exactly to make that work with the YAML tests.

hrishin added a commit to hrishin/tekton-pipeline that referenced this issue Sep 14, 2019
@hrishin
Enhancements for PullRequest Resource docs
ed78271 
It seems like users may not able able to understand
how to use the `PullRequestResource` with secret configuration.

This patch updates the docs with example Task with Secret
to demonstrate how to use the PR Resource.

Fixes tektoncd#1275
@hrishin
Copy link
Member Author

hrishin commented Sep 14, 2019

@sbwsg 👍

tekton-robot pushed a commit that referenced this issue Sep 16, 2019
@hrishin @tekton-robot
Enhancements for PullRequest Resource docs
f12922f 
It seems like users may not able able to understand
how to use the `PullRequestResource` with secret configuration.

This patch updates the docs with example Task with Secret
to demonstrate how to use the PR Resource.

Fixes #1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancements for PullRequest Resource docs hrishin/tekton-pipeline
2 participants
@vincent-pli @hrishin