Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and simplify InputSourceBindings and OutputSourceBindings #139

Closed
tejal29 opened this issue Oct 12, 2018 · 1 comment · Fixed by #248
Closed

Document and simplify InputSourceBindings and OutputSourceBindings #139

tejal29 opened this issue Oct 12, 2018 · 1 comment · Fixed by #248
Assignees
Labels
area/user-study design This task is about creating and discussing a design

Comments

@tejal29
Copy link
Contributor

tejal29 commented Oct 12, 2018

Expected Behavior

Given a task, user should be able to use it in a pipeline easily.

Actual Behavior

Right now, a task defines inputs and outputs. However, when using them in a pipeline, they need to be mapped to inputSourceBindings and outputSourceBindings
User finds it difficult to specify the input to a task in a pipeline.

The sourceBindings portion of the field names is confusing to users and doesn't add a lot.

@bobcatfish bobcatfish added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 12, 2018
@bobcatfish bobcatfish added this to the 0.0.1 Alpha release milestone Nov 3, 2018
@bobcatfish bobcatfish changed the title Document InputSourceBindings and OutputSourceBindings Document and simplify InputSourceBindings and OutputSourceBindings Nov 6, 2018
@bobcatfish bobcatfish added design This task is about creating and discussing a design and removed kind/documentation Categorizes issue or PR as related to documentation. labels Nov 6, 2018
@bobcatfish
Copy link
Collaborator

I think I'm gonna take care of this as part of the changes I'm making for #200

@bobcatfish bobcatfish self-assigned this Nov 20, 2018
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Nov 21, 2018
This change makes it possible to reuse a Pipeline with different
Resources without having to change the Pipeline itself. It does this by
moving the linking of the Resources a Task requires from the Pipeline
into the PipelineRun.

The relationship between Resources and the Tasks that are expected to be
executed on them is still expressed in the Pipeline (via `providedBy`).

ResourceBindings move from Pipeline to PipelineRun and become
ResourceDependencies. No longer calling these "bindings" in the API or
using the term "source" fixes + the additional docs in using.md fixes tektoncd#139.

The most difficult part of this change was updating
validatePipelineTaskAndTask - hoping to refactor this in a follow up
(which would also address tektoncd#213).

This interface is still probably not in its final form and hopefully we
can iterate on it!

Fixes tektoncd#200
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Nov 21, 2018
This change makes it possible to reuse a Pipeline with different
Resources without having to change the Pipeline itself. It does this by
moving the linking of the Resources a Task requires from the Pipeline
into the PipelineRun.

The relationship between Resources and the Tasks that are expected to be
executed on them is still expressed in the Pipeline (via `providedBy`).

ResourceBindings move from Pipeline to PipelineRun and become
ResourceDependencies. No longer calling these "bindings" in the API or
using the term "source" fixes + the additional docs in using.md fixes tektoncd#139.

The most difficult part of this change was updating
validatePipelineTaskAndTask - hoping to refactor this in a follow up
(which would also address tektoncd#213).

This interface is still probably not in its final form and hopefully we
can iterate on it!

Fixes tektoncd#200
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Nov 22, 2018
This change makes it possible to reuse a Pipeline with different
Resources without having to change the Pipeline itself. It does this by
moving the linking of the Resources a Task requires from the Pipeline
into the PipelineRun.

The relationship between Resources and the Tasks that are expected to be
executed on them is still expressed in the Pipeline (via `providedBy`).

ResourceBindings move from Pipeline to PipelineRun and become
ResourceDependencies. No longer calling these "bindings" in the API or
using the term "source" fixes + the additional docs in using.md fixes tektoncd#139.

The most difficult part of this change was updating
validatePipelineTaskAndTask - hoping to refactor this in a follow up
(which would also address tektoncd#213).

This interface is still probably not in its final form and hopefully we
can iterate on it!

Fixes tektoncd#200
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Nov 22, 2018
This change makes it possible to reuse a Pipeline with different
Resources without having to change the Pipeline itself. It does this by
moving the linking of the Resources a Task requires from the Pipeline
into the PipelineRun.

The relationship between Resources and the Tasks that are expected to be
executed on them is still expressed in the Pipeline (via `providedBy`).

ResourceBindings move from Pipeline to PipelineRun and become
ResourceDependencies. No longer calling these "bindings" in the API or
using the term "source" fixes + the additional docs in using.md fixes tektoncd#139.

The most difficult part of this change was updating
validatePipelineTaskAndTask - hoping to refactor this in a follow up
(which would also address tektoncd#213).

This interface is still probably not in its final form and hopefully we
can iterate on it!

Fixes tektoncd#200
knative-prow-robot pushed a commit that referenced this issue Nov 22, 2018
This change makes it possible to reuse a Pipeline with different
Resources without having to change the Pipeline itself. It does this by
moving the linking of the Resources a Task requires from the Pipeline
into the PipelineRun.

The relationship between Resources and the Tasks that are expected to be
executed on them is still expressed in the Pipeline (via `providedBy`).

ResourceBindings move from Pipeline to PipelineRun and become
ResourceDependencies. No longer calling these "bindings" in the API or
using the term "source" fixes + the additional docs in using.md fixes #139.

The most difficult part of this change was updating
validatePipelineTaskAndTask - hoping to refactor this in a follow up
(which would also address #213).

This interface is still probably not in its final form and hopefully we
can iterate on it!

Fixes #200
chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this issue Sep 30, 2019
Fixes for CI Breakage due to upstream example modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-study design This task is about creating and discussing a design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants