PipelineRun should directly support per TaskRun runtime settings

[skaegi]

PipelineRun's currently let us set a serviceAccount and podTemplate that is copied down to all child TaskRuns. We added serviceAccountNames as a per task mapping, but I can see now we are likely to need the same thing for podTemplates to handle variations on things like imagePullSecret, runtimeClass, nodeSelector etc.

What I'd suggest is that we have a tasks property in PipelineRun that to start contains 'serviceAccountNameandpodTemplate`.

e.g.

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: my-pipeline-run
spec:
  ...
  serviceAccountName: basic
  podTemplate: {...some useful settings}
  tasks:
    - name: myTask1
      serviceAccountName: xyzzy
      podTemplate: {} # empty
    - name: myTask3
      serviceAccountName: abc

All TaskRuns use the top-level serviceAccountName and podTemplate unless over-ridden in the per task mappings. For serviceAccountNames we could either eventually deprecate it or support it forever.

[vdemeester]

/kind feature

[NikeNano]

I would be happy to work on this!

[NikeNano]

I start on a PR in the mean time, hope that is fine :)

[ghost]

Now that #2389 is merged, can we close this issue? Or is there more work to do here?

[vdemeester]

I think so yes !
/close

[tekton-robot]

@vdemeester: Closing this issue.

In response to this:

I think so yes !
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.