Remove tekton.dev/task label from ClusterTask TaskRuns #2533
Labels
area/api
Indicates an issue or PR that deals with the API.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lifecycle/frozen
Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Comments
|
This was announced as deprecated in 0.12.0 so should be removable from Pipelines on/after Jan 30 2021 |
|
PR #2527 for it but needs to be merged later |
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
|
Can I suggest that we close this until the deprecation window has closed? I'd prefer not to keep this PR open for 9 months. What do others think? I've documented the deprecation of the annotation here: https://github.com/tektoncd/pipeline/blob/master/docs/deprecations.md Edit: oops, this is the issue. This should stay open. It's the PR I'm talking about here. |
|
I got error: 'error: unable to recognize "tekton/tasks/source-to-image.yaml": no matches for kind "Task" in version "tekton.dev/v1beta1"' today and it worked last week. Is this related to this depreciation? Thank you |
|
@lee-zhg no, this change wasn't merged yet so it's unlikely to be related. Feel free to create a new issue if your problem persists. Please include any more information you can - Tekton version, the Task YAML, etc. |
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
tekton-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
tekton-robot
removed
the
lifecycle/stale
4 tasks
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
tekton-robot
added
the
lifecycle/stale
|
As this is a deprecation "follow-up", let's not mark it as stale /remove-lifecycle stale |
tekton-robot
added
lifecycle/frozen
piyush-garg
added a commit
to piyush-garg/pipeline
that referenced
this issue
Feb 15, 2021
This will remove the label tekton.dev/clusterTask label from taskruns which are referencing a clusterTask. This was marked deprecated in v0.12.0 Fix tektoncd#2533
4 tasks
piyush-garg
added a commit
to piyush-garg/pipeline
that referenced
this issue
Feb 16, 2021
This will remove the label tekton.dev/task label from taskruns which are referencing a clusterTask. This was marked deprecated in v0.12.0 Fix tektoncd#2533
|
/milestone v0.21.0 |
tekton-robot
pushed a commit
that referenced
this issue
Mar 9, 2021
This will remove the label tekton.dev/task label from taskruns which are referencing a clusterTask. This was marked deprecated in v0.12.0 Fix #2533
afrittoli
added a commit
to afrittoli/pipeline
that referenced
this issue
Feb 16, 2022
The tekton.dev/task label for ClusterTasks have been removed in tektoncd#2533, but the table has not been updated yet, so doing it in here. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot
pushed a commit
that referenced
this issue
Feb 16, 2022
The tekton.dev/task label for ClusterTasks have been removed in #2533, but the table has not been updated yet, so doing it in here. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
pxp928
added a commit
to pxp928/pipeline
that referenced
this issue
Feb 17, 2022
* cleanup - ApplyContext parameters Instead of passing around the entire resolvedTaskResources, which is not necessary at this point, just pass the task name. No functional changes expected. * use podtemplate imagepullsecrets to resolve entrypoint * Update write_test.go Fixed a typo * Fix links to Why Aren't PipelineResources in Beta? Links to the "Why Aren't PipelineResources in Beta?" section in the docs should have `aren-t` in the fragment instead of `arent`. This can be confirmed by clicking the link icon beside the heading and checking the browser address bar. * Fix tekton_pipelines_controller_taskrun_count recount bug Added before and after condition check to avoid taskrun metrics recount bug. * debug is an alpha feature Documenting that the debug feature is still alpha. The feature was introduced in pipelines release 0.26 behind enable-api-fields flag. * Consider osversion when determining platform uniqueness Prior to this change, an image (such as `golang:1.17`) that provided two images that shared the same OS+architecture+variant would be considered invalid, even if they described two different images whose platforms differed on, for example, osversion (used by Windows images). This change relaxes our platform uniqueness logic to take this into account, unblocking Linux users from running such images. There's still an issue for Windows users however, since when they attempt to run these images they'll fail to find the correct command taking into account their osversion. Workarounds in this case include specifying a single-platform image, or avoiding multi-platform images that provide two Windows images differing only by osversion. This also updates our selection logic to take into account slightly malformed multi-platform images that specify two images with the same OS+architecture[+variant], so long as the duplicate entries describe the same image by digest (e.g., anchore/syft:v0.37.10) * [TEP-0059] Scope `when` expressions to `Task` only In [TEP-0007: Conditions Beta][tep-0007], we introduced `when` expressions to guard execution of `Tasks` in `Pipelines`. To align with `Conditions`, we set scope of `when` expressions to the guarded `Task` and its dependent `Tasks`. In [TEP-0059: Skipping Strategies][tep-0059], we proposed changing the scope of `when` expressions to the guarded `Task` only. This was implemented in tektoncd#4085. We provided a feature flag, `scope-when-expressions-to-task`, to support migration. It defaulted to `false` for 9 months per our [Beta API compatibility policy][policy], meaning that we continued to guard the `Task` and its dependent `Tasks`. In this change, we flip the flag to `true` to guard the `Task` only by default. [tep-0007]: https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md [tep-0059]: https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md [policy]: https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md * Update the `scope-when-expressions-to-task` feature flag docs In tektoncd#4580, we changed the flag default from "false" to "true". However, the documentation above the flag was still describing what setting it to "true" would do. In this change, we update the documentation to focus on the non-default option that users can choose to set - "false". We also add a reference to TEP-0059 and relevant docs for more details. * Patch temp GOPATH hack script to handle nounset option Prior to this commit the setup-temporary-gopath.sh used the GOPATH variable without first checking that it was set. When `set -o nounset` is working this causes the script to exit with an error. This commit adds a variable wrapping $GOPATH and setting a default if it's missing, which should work around the `nounset`. * use helper functions - MarkResource* Replace updating the conditions directly with the helper functions - MarkResourceRunning and MarkRunning. No functional change expected. * Update the deprecations table The tekton.dev/task label for ClusterTasks have been removed in tektoncd#2533, but the table has not been updated yet, so doing it in here. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com> * Remove deprecated flags home-env and working-dir This change removes two flags: - disable-home-env-overwrite - disable-working-dir-overwrite That two flags that were originally introduced with default to false and the feature associated to them was deprecated. Nine months later (as per policy), in Dec 2020, the default value was switched to default true and the flags were deprecated. Nine months later we are finally removing the flags. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com> * Fix for some arm64 machines. As said in GoogleContainerTools/distroless#657, in the past, distroless/base:debug used an arm32 busybox binary in its arm64 image. Which doesn't work on some arm64 machines, e.g., Ubuntu 21 arm64 on Parallel Desktop on Apple Silicon M1. It caused this error: " $ docker run -it gcr.io/distroless/base@sha256:cfdc553400d41b47fd231b028403469811fcdbc0e69d66ea8030c5a0b5fbac2b standard_init_linux.go:228: exec user process caused: exec format error " This PR GoogleContainerTools/distroless#960 fixes this bug. Hence, update the distroless/base:debug used by Tekton Pipeline in this commit. * Add Step and Sidecar Overrides to TaskRun API This commit adds TaskRunStepOverrides and TaskRunSidecarOverrides to TaskRun.Spec and PipelineRun.Spec.PipelineTaskRunSpec, gated behind the "alpha" API flag. This is part 1 of implementing TEP-0094: Configuring Resource Requirements at Runtime. https://github.com/tektoncd/community/blob/main/teps/0094-configuring-resources-at-runtime.md * WIP spire. Signed-off-by: Dan Lorenc <dlorenc@google.com> changed to use spiffe-csi Add pod SPIFFE id annotation for workload registrar Signed-off-by: Brandon Lum <lumjjb@gmail.com> removed spire jwt updated obtaining trust bundle Added SPIFFE entry registration and SVID entrypointer backoff (#2) * Added SPIFFE entry registration and SVID entrypointer backoff Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Allow SPIRE configuration through opts Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Add validation of SpireConfig Signed-off-by: Brandon Lum <lumjjb@gmail.com> * merged upstream Signed-off-by: pxp928 <parth.psu@gmail.com> * added manifest check * [WIP] Add SPIRE docs (#4) * merged upstream * Add several features/optimizations for SPIRE (#3) * Record pod latency before SPIRE entry creation Signed-off-by: Brandon Lum <lumjjb@gmail.com> * SPIRE client connection caching Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Optimize spire entry creation Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Add TTL for workload entry based on taskrun timeout Signed-off-by: Brandon Lum <lumjjb@gmail.com> * Add SPIRE non-falsification doc Signed-off-by: Brandon Lum <lumjjb@gmail.com> Co-authored-by: pxp928 <parth.psu@gmail.com> * merged upstream Signed-off-by: pxp928 <parth.psu@gmail.com> Co-authored-by: pritidesai <pdesai@us.ibm.com> Co-authored-by: Yongxuan Zhang <yongxuanzhang@google.com> Co-authored-by: Anupama Baskar <anu.baskar@ibm.com> Co-authored-by: Alan Greene <github.com@alangreene.net> Co-authored-by: Khurram Baig <kbaig@redhat.com> Co-authored-by: Jason Hall <jasonhall@redhat.com> Co-authored-by: Jerop <jerop@google.com> Co-authored-by: Scott <sbws@google.com> Co-authored-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com> Co-authored-by: Meng-Yuan Huang <myh@live.com> Co-authored-by: Lee Bernick <lee.a.bernick@gmail.com> Co-authored-by: Dan Lorenc <dlorenc@google.com> Co-authored-by: Brandon Lum <lumjjb@gmail.com>
khrm
pushed a commit
to openshift/tektoncd-pipeline
that referenced
this issue
May 19, 2022
The tekton.dev/task label for ClusterTasks have been removed in tektoncd#2533, but the table has not been updated yet, so doing it in here. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
TaskRuns started from a ClusterTask should only have the label
tekton.dev/clusterTask=<task name>.Actual Behavior
TaskRuns started from ClusterTasks currently receive both
tekton.dev/clusterTask=andtekton.dev/task=.Steps to Reproduce the Problem
tekton.dev/tasklabelThe text was updated successfully, but these errors were encountered: