-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End to end test migration from build #302
Milestone
Comments
bobcatfish
added
the
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
label
Dec 4, 2018
bobcatfish
changed the title
End to end test strategy & migration from build
End to end test migration from build
Dec 4, 2018
bobcatfish
removed
the
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
label
Dec 4, 2018
/assign @shashwathi |
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 12, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements.
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 13, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 13, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 13, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 13, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 13, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 14, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 14, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 14, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 15, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
shashwathi
pushed a commit
to shashwathi/build-pipeline
that referenced
this issue
Feb 15, 2019
Fixes tektoncd#302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
knative-prow-robot
pushed a commit
that referenced
this issue
Feb 15, 2019
Fixes #302 what: Add yaml tests which cover different features of knative build in knative build pipeline like mounting secret as volume, templating arguements. list build yamls tests are not added: - build with `source` key. As build added support for multiple sources build examples included both `source` and `sources` key version of build. In taskrun world it means the same thing (https://github.com/knative/build/tree/master/test/sources) - build subpath feature is not supported in taskrun (https://github.com/knative/build/tree/master/test/subpath) - build with multiple steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple steps - build that panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported in yaml - build with timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in e2e go test - build with custom source. Taskrun does nto support custom source (https://github.com/knative/build/tree/master/test/custom-source) - build that fails (https://github.com/knative/build/tree/master/test/fail). Taskrun does not support failed taskruns - build with step status (https://github.com/knative/build/tree/master/test/step-status). go e2e tests already cover this feature - build yaml tests git-init image directly. This is indirectly testing git resource and does not add much value. (https://github.com/knative/build/tree/master/test/reuse-git-init)
bobcatfish
added
okr
This is for some internal Google project tracking
and removed
okr
This is for some internal Google project tracking
labels
Feb 21, 2019
waveywaves
pushed a commit
to waveywaves/tekton-pipeline
that referenced
this issue
Feb 12, 2020
Fix Command to disable_gcp
pradeepitm12
pushed a commit
to pradeepitm12/pipeline
that referenced
this issue
Jan 28, 2021
Codeblocks were marked as yaml, even though that are shell commands. This caused issues when autoformatting documentation (i.e. tektoncd#302).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
If we move the functionality offered by
knative/build
over to this repo, we should also have the same test coverage for it over here. This means migrating all of the existing end to end tests fromknative/build
over to this repo (the migration guide we'll be creating in #250 should be useful!).Actual Behavior
Tests only exist in
knative/build
(yaml tests, end to end tests, other tests?)Additional Info
Blocked by #252No longer blockedNow blocked by #313 which would be needed to do this.
The text was updated successfully, but these errors were encountered: