Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of when expressions #4461

Closed
2 of 3 tasks
jerop opened this issue Jan 10, 2022 · 1 comment · Fixed by #4715, #4580 or #4584
Closed
2 of 3 tasks

Scope of when expressions #4461

jerop opened this issue Jan 10, 2022 · 1 comment · Fixed by #4715, #4580 or #4584
Assignees
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jerop
Copy link
Member

jerop commented Jan 10, 2022

As documented in the deprecations, we are migrating the scope of when expressions.

Feature Being Deprecated Deprecation Announcement API Compatibility Policy Earliest Date or Release of Removal
The scope-when-expressions-to-task flag will be flipped from "false" to "true" v0.27.0 Beta February 10 2022
The scope-when-expressions-to-task flag will be removed v0.27.0 Beta March 10 2022

For more information, read TEP-0059: Skipping Strategies and related announcement.

This is issue is tracking the work that we need to do here in the February and March releases.

/kind feature
/assign


Pull Requests

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2022
jerop added a commit to jerop/pipeline that referenced this issue Jan 10, 2022
Today, those announcements link to tektoncd#1836 which is an unrelated issue. 

In this change, we add a link to the issue tracking that work - tektoncd#4461
tekton-robot pushed a commit that referenced this issue Jan 10, 2022
Today, those announcements link to #1836 which is an unrelated issue. 

In this change, we add a link to the issue tracking that work - #4461
@jerop jerop added this to the Pipelines v0.33 milestone Jan 25, 2022
afrittoli added a commit to afrittoli/pipeline that referenced this issue Feb 16, 2022
Switch the default value for scope-when-expressions-to-task to true,
as documented in the deprecations table.

This is step is in preparation for the complete removal of the flag
coming in the next release.

Related to tektoncd#4461

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@jerop jerop added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Feb 17, 2022
@jerop jerop moved this to In Progress in Tekton Pipelines Roadmap Feb 17, 2022
@pritidesai
Copy link
Member

Pipelines WG - Remove the flag in 0.35

jerop added a commit to jerop/pipeline that referenced this issue Mar 29, 2022
In [TEP-0007: Conditions Beta][tep-0007], we introduced `when` expressions to guard
execution of `Tasks` in `Pipelines`. To align with `Conditions`, we set scope of
`when` expressions to the guarded `Task` and its dependent `Tasks`.

In [TEP-0059: Skipping Strategies][tep-0059], we proposed changing the scope of
`when` expressions to the guarded `Task` only. This was implemented in tektoncd#4085.
We provided a feature flag, `scope-when-expressions-to-task`, to support migration.
It defaulted to `false` for 9 months per our [Beta API compatibility policy][policy],
meaning that we continued to guard the `Task` and its dependent `Tasks`. Then in tektoncd#4580,
we flipped the flag to `true` to guard the `Task` only by default.

In this change, we remove the `scope-when-expressions-to-task` flag and complete the
migration.

Closes tektoncd#4461.

[tep-0007]: https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md
[tep-0059]: https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md
[policy]: https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md
jerop added a commit to jerop/pipeline that referenced this issue Mar 29, 2022
In [TEP-0007: Conditions Beta][tep-0007], we introduced `when` expressions to guard
execution of `Tasks` in `Pipelines`. To align with `Conditions`, we set scope of
`when` expressions to the guarded `Task` and its dependent `Tasks`.

In [TEP-0059: Skipping Strategies][tep-0059], we proposed changing the scope of
`when` expressions to the guarded `Task` only. This was implemented in tektoncd#4085.
We provided a feature flag, `scope-when-expressions-to-task`, to support migration.
It defaulted to `false` for 9 months per our [Beta API compatibility policy][policy],
meaning that we continued to guard the `Task` and its dependent `Tasks`. Then in tektoncd#4580,
we flipped the flag to `true` to guard the `Task` only by default.

In this change, we remove the `scope-when-expressions-to-task` flag and complete the
migration.

Closes tektoncd#4461.

[tep-0007]: https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md
[tep-0059]: https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md
[policy]: https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md
Repository owner moved this from In Progress to Done in Tekton Pipelines Roadmap Mar 29, 2022
tekton-robot pushed a commit that referenced this issue Mar 29, 2022
In [TEP-0007: Conditions Beta][tep-0007], we introduced `when` expressions to guard
execution of `Tasks` in `Pipelines`. To align with `Conditions`, we set scope of
`when` expressions to the guarded `Task` and its dependent `Tasks`.

In [TEP-0059: Skipping Strategies][tep-0059], we proposed changing the scope of
`when` expressions to the guarded `Task` only. This was implemented in #4085.
We provided a feature flag, `scope-when-expressions-to-task`, to support migration.
It defaulted to `false` for 9 months per our [Beta API compatibility policy][policy],
meaning that we continued to guard the `Task` and its dependent `Tasks`. Then in #4580,
we flipped the flag to `true` to guard the `Task` only by default.

In this change, we remove the `scope-when-expressions-to-task` flag and complete the
migration.

Closes #4461.

[tep-0007]: https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md
[tep-0059]: https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md
[policy]: https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
4 participants