Some *useful* Pod status do not bubble up in TaskRun status #4802
Comments
vdemeester
added
kind/bug
|
Hi, I am interested in this issue. May I take this one? If I need any help I will mention it here. Thank you! |
|
/assign yuzp1996 |
|
I think I have reproduced the error here. The pod is in the status of ImagePullBackOff while the related Taskrun is pending. I think the expected result is that the Taskrun should fail with a clear message/reason based on it. If I misunderstand something please tell me. Thank you! |
|
Hi, I check the code and find maybe we can do some improvement here. I think this is not a bug fix but a new feature. Maybe I need to provide a TEP to describe the goal that we want to achieve and the code change that I need to make. I will be very happy if you can give me some advice. @vdemeester Thanks! |
|
So Yeah this is probably a new feature, but I don't think it needs a TEP, just a proper pull request explaining the new errors we handle should be fine. |
|
OK, thanks! I will do it this week. |
fix/feature: tektoncd#4802
|
This is all the image related error I found in the k8s kubelet code base. I will try to bubble up all these errors in TaskRun status.
|
When pod is pending because of failure of pulling image the users can not get the clear reason or message from the taskrun status. Now I will check the pod status and judge if the error is caused by image if so the error reason and message will bubble up to taskrun status. Then user can know what happend though the taskrun status. Related issue: tektoncd#4802 Signed-off-by: yuzhipeng <yuzp1996@qq.com>
When pod is pending because of failure of pulling image the users can not get the clear reason or message from the taskrun status. Now I will check the pod status and judge if the error is caused by image if so the error reason and message will bubble up to taskrun status. Then user can know what happend though the taskrun status. Related issue: tektoncd#4802 Signed-off-by: yuzhipeng <yuzp1996@qq.com>
When pod is pending because of failure of pulling image the users can not get the clear reason or message from the taskrun status. Now I will check the pod status and judge if the error is caused by image if so the error reason and message will bubble up to taskrun status. Then user can know what happend though the taskrun status. Related issue: tektoncd#4802 Signed-off-by: yuzhipeng <yuzp1996@qq.com>
When pod is pending because of failure of pulling image the users can not get the clear reason or message from the taskrun status. Now I will check the pod status and judge if the error is caused by image if so the error reason and message will bubble up to taskrun status. Then user can know what happend though the taskrun status. Related issue: tektoncd#4802 Signed-off-by: yuzhipeng <yuzp1996@qq.com>
When pod is pending because of failure of pulling image the users can not get the clear reason or message from the taskrun status. Now I will check the pod status and judge if the error is caused by image if so the error reason and message will bubble up to taskrun status. Then user can know what happend though the taskrun status. Related issue: #4802 Signed-off-by: yuzhipeng <yuzp1996@qq.com>
Sligtly related to #4801, when a
Poddoesn't fail but is in a "long-term" un-reconciliable state, such asInvalidImageName, theTaskRuncontroller ignore those and wait forever (aka timeout).This happens because it a fixable error from the
Podstandpoint (you can mutate theimageof a container in aPod), and thus doesn't seem to be considered as a "terminal" error.The
TaskRuncontroller should pickup these kind of error (at leastInvalidImageName, but most likely there might be a few other status that make sense) and fail with a clear message/reason based on it.The text was updated successfully, but these errors were encountered: