Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Task controller for testing #5120

Closed
lbernick opened this issue Jul 11, 2022 · 5 comments
Closed

Custom Task controller for testing #5120

lbernick opened this issue Jul 11, 2022 · 5 comments
Assignees
Labels
area/testing Issues or PRs related to testing

Comments

@lbernick
Copy link
Member

In order to write better integration/e2e tests for custom Tasks, it would be useful to have a controller that watches for Runs of some kind we just use for testing, and install this controller when running e2e tests. This controller could do any of:

  • wait indefinitely
  • set the status to "succeeded"
  • set the status to match some boolean succeeded/failed set in the spec.

This controller shouldn't be packaged with Tekton releases.

@lbernick lbernick added the area/testing Issues or PRs related to testing label Jul 11, 2022
@jerop
Copy link
Member

jerop commented Jul 11, 2022

@XinruZhang
Copy link
Member

/assign XinruZhang

@XinruZhang
Copy link
Member

Thanks for writing the issue Lee! I may need some extra clarifications:

set the status to match some boolean succeeded/failed set in the spec.

Do you mean we define some boolean fields in the spec and set those fields in status as what are set in the spec.

This controller shouldn't be packaged with Tekton releases.

Will codes under test/ be packaged with Tekton release?

@XinruZhang
Copy link
Member

Hi @lbernick what do we need for the wait infinitely? Is the current wait-task controller enough?

@lbernick
Copy link
Member Author

This was just a suggestion of what we could write the controller to do-- I was just brainstorming simple behaviors that are easy to understand for testing. It really depends on what tests we want to add and what controller behavior would be most helpful for those tests. It seems to me like the wait task has given us what we need? So I'm going to close this as completed in #5332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing
Projects
None yet
Development

No branches or pull requests

3 participants