Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0114: Custom Task E2E Test with A Controller Installed #5332

Merged
merged 1 commit into from
Aug 19, 2022
Merged

TEP-0114: Custom Task E2E Test with A Controller Installed #5332

merged 1 commit into from
Aug 19, 2022

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Aug 16, 2022 •
edited
Loading

This PR introduces a wait-task controller into test/ folder to
better support Custom Task e2e testing.

Previously we update the Run object to mimic the behavior of a custom
task controller. This pr introduces a real controller to reconcile
the custom task run.

Changes

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 16, 2022
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2022
@XinruZhang
Copy link
Member Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 16, 2022
@lbernick lbernick self-assigned this Aug 16, 2022
jerop
jerop reviewed Aug 16, 2022
View reviewed changes
test/wait-task/tekton/README.md Outdated Show resolved Hide resolved
test/wait-task/README.md Outdated Show resolved Hide resolved
@jerop jerop self-assigned this Aug 16, 2022
@XinruZhang XinruZhang force-pushed the wait-task-in-pipeline branch 3 times, most recently from 7606134 to 1137187 Compare August 16, 2022 20:42
@XinruZhang
Copy link
Member Author

/retest

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 16, 2022
dibyom
dibyom reviewed Aug 17, 2022
View reviewed changes
test/wait-task/LICENSE Outdated Show resolved Hide resolved
@XinruZhang
Copy link
Member Author

/retest

1 similar comment
@XinruZhang
Copy link
Member Author

/retest

jerop
jerop reviewed Aug 17, 2022
View reviewed changes
test/custom_task_test.go Outdated Show resolved Hide resolved
@bendory
Copy link
Contributor

bendory commented Aug 17, 2022

This cl introduces a real controller to reconcile the custom task run.

Nit: "This PR introduces..." CLs (changelists) are a Google thing, PRs are a GitHub thing. 😺

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@XinruZhang XinruZhang force-pushed the wait-task-in-pipeline branch 2 times, most recently from 256aab8 to d908d05 Compare August 18, 2022 18:26
@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@XinruZhang XinruZhang force-pushed the wait-task-in-pipeline branch 2 times, most recently from d59dc71 to e4cbbfb Compare August 19, 2022 14:16
@XinruZhang
Copy link
Member Author

/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2022
jerop
jerop reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinruZhang thanks for making updates from the initial offline review -- added a few comments, almost there 😁

test/custom_task_test.go Show resolved Hide resolved
test/custom_task_test.go Show resolved Hide resolved
test/custom_task_test.go Outdated Show resolved Hide resolved
test/wait-task/pkg/reconciler/reconciler.go Outdated Show resolved Hide resolved
test/wait.go Outdated Show resolved Hide resolved
@jerop jerop changed the title Custom Task E2E Test with A Controller Installed TEP-0114: Custom Task E2E Test with A Controller Installed Aug 19, 2022
@XinruZhang XinruZhang force-pushed the wait-task-in-pipeline branch 2 times, most recently from e76577d to dd3c972 Compare August 19, 2022 15:43
@XinruZhang
Custom Task E2E Test with A Controller Installed
058df12 
This commit introduces a `wait-task` controller into test/ folder to
better support Custom Task e2e testing.

Previously we update the Run object to mimic the behavior of a custom
task controller. This commit introduces a real controller to reconcile
the custom task run.
@XinruZhang
Copy link
Member Author

/retest

jerop
jerop approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XinruZhang, and welcome to Tekton! 🎉

/meow

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

Thank you @XinruZhang, and welcome to Tekton! 🎉

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@lbernick
Copy link
Member

/woof

@tekton-robot
Copy link
Collaborator

@lbernick: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Aug 19, 2022

/meow

@tekton-robot
Copy link
Collaborator

@dibyom: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XinruZhang
Copy link
Member Author

/meow

@tekton-robot
Copy link
Collaborator

@XinruZhang: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dibyom
dibyom reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@tekton-robot tekton-robot merged commit acf50a1 into tektoncd:main Aug 19, 2022
@XinruZhang XinruZhang mentioned this pull request Aug 19, 2022
Closed
@lbernick lbernick mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@jerop jerop jerop approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dibyom dibyom

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XinruZhang @bendory @tekton-robot @lbernick @dibyom @jerop