-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline uses passedConstraints
to provide correct inputs and outputs
#65
Labels
meaty-juicy-coding-work
This task is mostly about implementation!!! And docs and tests of course but that's a given
Comments
bobcatfish
referenced
this issue
in bobcatfish/pipeline
Oct 11, 2018
PipelineRun status will be based on the condition of the TaskRuns which it has created, for #61. If any TaskRuns have failed, the PipelineRun has failed. If all are successful, it is successful. If any are in progress, it is in progress. This is assuming a linear Pipeline, we will have to tweak this a bit when we implement the graph (for #65)
bobcatfish
referenced
this issue
in bobcatfish/pipeline
Oct 11, 2018
PipelineRun status will be based on the condition of the TaskRuns which it has created, for #61. If any TaskRuns have failed, the PipelineRun has failed. If all are successful, it is successful. If any are in progress, it is in progress. This is assuming a linear Pipeline, we will have to tweak this a bit when we implement the graph (for #65)
bobcatfish
added
the
meaty-juicy-coding-work
This task is mostly about implementation!!! And docs and tests of course but that's a given
label
Oct 12, 2018
bobcatfish
referenced
this issue
in bobcatfish/pipeline
Oct 12, 2018
PipelineRun status will be based on the condition of the TaskRuns which it has created, for #61. If any TaskRuns have failed, the PipelineRun has failed. If all are successful, it is successful. If any are in progress, it is in progress. This is assuming a linear Pipeline, we will have to tweak this a bit when we implement the graph (for #65)
knative-prow-robot
pushed a commit
that referenced
this issue
Oct 13, 2018
PipelineRun status will be based on the condition of the TaskRuns which it has created, for #61. If any TaskRuns have failed, the PipelineRun has failed. If all are successful, it is successful. If any are in progress, it is in progress. This is assuming a linear Pipeline, we will have to tweak this a bit when we implement the graph (for #65)
lol the passedConstraints - literally the most important part of this task - are missing from the example! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
meaty-juicy-coding-work
This task is mostly about implementation!!! And docs and tests of course but that's a given
Expected Behavior
If a user creates a Pipeline which has
passedConstraints
specified, this should be used to construct a DAG of tasks (including fan in and fan out)2. Ensure that the version of the
Resource
used by the task is the same as the version used by theTask
(s) in thepassedConstraint
Should include:
Resources
that are changed betweenTasks
and how to usepassedConstraints
to make sure the right versions are usedActual Behavior
After #61 we will have a simple
Pipeline
in which either the DAG is flat or allTasks
execute simultaneously; i.e. thepassedConstraints
are ignored.Steps to Reproduce the Problem
Resource
that brings in the hello-world docker image repo, and declares an image we will be building (gcr.io/my-registry
must be changed to a registry that the specified serviceAccounts will have permission to push to):Pipeline
which wires the twoTasks
together usingpassedConstraints
:PipelineRun
which invokes theTasks
(you'll have to create aPipelineParams
as well with yourserviceAccount
, in this case calledhello-world-params
:Creating the PipelineRun should have created TaskRuns with all of the values filled in, so with
kubectl get taskRuns
you should be able to see conditions updated appropriatelyLooking at the Task logs (if this has been implemented, see Implement working "hello world" Task + TaskRun #59) or at the logs for the running pod if not, you should be able to see that the hello world image was run and output the expected value from the hello world image
You should be able to see
hello-world image
built and pushed to your registry.Additional Info
The text was updated successfully, but these errors were encountered: