Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Loss of Deprecated Container Fields in v1 for Step LivenessProbes and etc. #6575

Closed
JeromeJu opened this issue Apr 24, 2023 · 2 comments · Fixed by #6619 or #6623
Closed

Handle Loss of Deprecated Container Fields in v1 for Step LivenessProbes and etc. #6575

JeromeJu opened this issue Apr 24, 2023 · 2 comments · Fixed by #6619 or #6623
Assignees
@XinruZhang
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Pipelines v0.48

Comments

@JeromeJu
Copy link
Member

Feature request

In pipeline/pkg/apis/pipeline/v1beta1/container_conversion.go v1beta1 we are converting a v1beta1 sidecar to a v1beta1 step, which doesn't have any information loss while during the v1-storage swap, converting a v1 sidecar to a v1 step would have information loss.

The script.go needs to be updated to ensure these fields are still supported in sidecars, and add tests for that functionality if they don't already exist.

Related to #4546

Use case
@JeromeJu JeromeJu added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2023
@JeromeJu JeromeJu mentioned this issue Apr 25, 2023
Closed
4 tasks
@lbernick lbernick moved this to Todo in Pipelines V1 Apr 25, 2023
@dibyom dibyom added this to the Pipelines v0.48 milestone Apr 25, 2023
@lbernick lbernick removed the kind/feature Categorizes issue or PR as related to a new feature. label Apr 26, 2023
@JeromeJu JeromeJu mentioned this issue Apr 27, 2023
Closed
@lbernick lbernick added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 27, 2023
@lbernick lbernick added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 3, 2023
This was referenced May 3, 2023
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Pipelines V1 May 5, 2023
@tekton-robot
Copy link
Collaborator

@XinruZhang: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot reopened this May 5, 2023
@pritidesai
Copy link
Member

Pipelines WG - in progress, expected to close this in 0.48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XinruZhang XinruZhang

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Pipelines V1
Status: Done
Milestone
Pipelines v0.48
6 participants
@pritidesai @dibyom @lbernick @XinruZhang @JeromeJu @tekton-robot