Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making easier to deploy with KO to different namespace #917

Closed
chmouel opened this issue May 28, 2019 · 5 comments
Closed

Making easier to deploy with KO to different namespace #917

chmouel opened this issue May 28, 2019 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chmouel
Copy link
Member

chmouel commented May 28, 2019 •
edited
Loading

RFE: Allow KO to deploy to different namespace easily

Currently KO don't allow easily to install to different namespace than the default 'tekton-pipelines' which is less than ideal for multi users dev clusters

It really only uses what's inside the config/*.yaml and it references tekton-pipelines

Suggestions:

  1. Templatize it (with kustomize or simple go template) and pre generate them before running ko. IE: with a make target

  2. Extend ko to allow override the namespace (if that could be accepted)

  3. Provide a KO wrapper that does this for us
@chmouel chmouel changed the title Making easier to develop to different namespace Making easier to deply with KO to different namespace May 28, 2019
@chmouel chmouel changed the title Making easier to deply with KO to different namespace Making easier to deploy with KO to different namespace May 28, 2019
@chmouel
Copy link
Member Author

chmouel commented May 28, 2019

/kind enhancement

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 28, 2019
@bobcatfish
Copy link
Collaborator

Another possible idea: switching to something other than ko

@imjasonh @jonjonsonjr any thoughts?

@jonjohnsonjr
Copy link
Contributor

This is possible if you aren't already specifying a namespace, see my comment here: google/go-containerregistry#295

I'd use ko in conjunction with another tool, like kustomize or even sed:

ko resolve -f config/ | sed 's/tekton-pipelines/other-namespace/g' | kubectl apply -f -

chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue Jun 11, 2019
@chmouel
Update documentation on how to dev to a custom namespace
6ddbf7b 
Making it easier to do a deployment to a custom namespace, providing a script
instead of doing manual steps.

The shell script will replace properly the fields to target the custom namespace
and add the environment variable for the downward API using `kubectl set env`

Fix bug tektoncd#917

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue Jun 11, 2019
@chmouel
Update documentation on how to dev to a custom namespace
628907e 
Making it easier to do a deployment to a custom namespace, providing a script
instead of doing manual steps.

The shell script will replace properly the fields to target the custom namespace
and add the environment variable for the downward API using `kubectl set env`

Fix bug tektoncd#917

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel added a commit to chmouel/tektoncd-pipeline that referenced this issue Jun 11, 2019
@chmouel
Update documentation on how to dev to a custom namespace
c505d13 
Making it easier to do a deployment to a custom namespace, providing a script
instead of doing manual steps.

The shell script will replace properly the fields to target the custom namespace
and add the environment variable for the downward API using `kubectl set env`

Fix bug tektoncd#917

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel mentioned this issue Jun 11, 2019
Merged
@chmouel
Copy link
Member Author

chmouel commented Jun 11, 2019

Thanks for the tip @jonjohnsonjr I have sent a PR to update our documentation in #972, the sed wasn't as straightforward, but i believe I figured it out to install it properly.

tekton-robot pushed a commit that referenced this issue Jun 12, 2019
@chmouel @tekton-robot
Update documentation on how to dev to a custom namespace
fa71d30 
Making it easier to do a deployment to a custom namespace, providing a script
instead of doing manual steps.

The shell script will replace properly the fields to target the custom namespace
and add the environment variable for the downward API using `kubectl set env`

Fix bug #917

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@dlorenc
Copy link
Contributor

dlorenc commented Oct 7, 2019

Closing as fixed by #972

@dlorenc dlorenc closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chmouel @bobcatfish @dlorenc @jonjohnsonjr @tekton-robot