Define new types for Cloud Events #1092

afrittoli · 2019-07-16T18:25:39Z

Changes

Define new types in TaskRun to hold the information and status
about cloud events to be delivered once a TaskRun is complete.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Implements in the TaskRun controller the logic to provide the cloud event pipeline resource. This commits puts together the API, cloud event helper and resource definition from three pull requests: - tektoncd#1090 - tektoncd#1091 - tektoncd#1092 It adds unit tests for the new code and one E2E YAML test. The YAML test runs a simple http server that can receive the cloudevent for test purposes. The list of cloud events to be sent is added to the TaskRun status and processed by the TaskRun controller once the pod associated to the TaskRun completes its execution. The `isDone` definition of the TaskRun is not altered, the reconciler checks for events to be sent once the TaskRun.isDone is true. Retries are not implemented yet in the sense that every scheduled event will be attempted exactly once, but it may be that those attempts happen across different invocations of Reconcile. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

tekton-robot · 2019-07-16T19:12:41Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/taskrun_types.go	72.7%	78.6%	5.8

Define new types in TaskRun to hold the information and status about cloud events to be delivered once a TaskRun is complete. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

tekton-robot · 2019-07-16T20:17:54Z

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/taskrun_types.go	72.7%	78.6%	5.8

dlorenc · 2019-07-22T14:32:43Z

/approve

tekton-robot · 2019-07-22T14:32:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dlorenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dlorenc · 2019-07-22T14:32:47Z

/lgtm

vdemeester

Maybe this has been discussed in the main PR, any reason to use CloudEvents instead of a notification type ? Cloud event could be "one" implementation of a notification type

afrittoli · 2019-07-22T17:02:05Z

@vdemeester my idea here was to have a simple solution for a CloudEvent base type of notification; but yeah we still need to tackle the topic of notifications more in general. This implementation gives you a nice way to do notifications that works well with triggers so we can soon start chaining tasks asynchronously.
I'm not opposed to the idea of introducing a NotificationResource that would be specialized into CloudEventResource but I feel that's something we could do as a follow-up?

vdemeester · 2019-07-22T17:24:20Z

I'm not opposed to the idea of introducing a NotificationResource that would be specialized into CloudEventResource but I feel that's something we could do as a follow-up?

Yeah, I was thinking outloud 👼

Implements in the TaskRun controller the logic to provide the cloud event pipeline resource. This commits puts together the API, cloud event helper and resource definition from four pull requests: - tektoncd#1090 - tektoncd#1091 - tektoncd#1092 - TBD TBD: address review comments TBD: test for interaction with the image digest export It adds unit tests for the new code and one E2E YAML test. The YAML test runs a simple http server that can receive the cloudevent for test purposes. The list of cloud events to be sent is added to the TaskRun status and processed by the TaskRun controller once the pod associated to the TaskRun completes its execution. The `isDone` definition of the TaskRun is not altered, the reconciler checks for events to be sent once the TaskRun.isDone is true. Retries are not implemented yet in the sense that every scheduled event will be attempted exactly once, but it may be that those attempts happen across different invocations of Reconcile. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

Implements in the TaskRun controller the logic to provide the cloud event pipeline resource. This commits puts together the API, cloud event helper and resource definition from four pull requests: - tektoncd#1090 - tektoncd#1091 - tektoncd#1092 TBD: Test for interaction with the image digest export It adds unit tests for the new code and one E2E YAML test. The YAML test runs a simple http server that can receive the cloudevent for test purposes. The list of cloud events to be sent is added to the TaskRun status and processed by the TaskRun controller once the pod associated to the TaskRun completes its execution. The `isDone` definition of the TaskRun is not altered, the reconciler checks for events to be sent once the TaskRun.isDone is true. Retries are not implemented yet in the sense that every scheduled event will be attempted exactly once, but it may be that those attempts happen across different invocations of Reconcile. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

Implements in the TaskRun controller the logic to provide the cloud event pipeline resource. This commits puts together the API, cloud event helper and resource definition from four pull requests: - tektoncd#1090 - tektoncd#1091 - tektoncd#1092 It adds unit tests for the new code and one E2E YAML test. The YAML test runs a simple http server that can receive the cloudevent for test purposes. The list of cloud events to be sent is added to the TaskRun status and processed by the TaskRun controller once the pod associated to the TaskRun completes its execution. The `isDone` definition of the TaskRun is not altered, the reconciler checks for events to be sent once the TaskRun.isDone is true. Retries are not implemented yet in the sense that every scheduled event will be attempted exactly once, but it may be that those attempts happen across different invocations of Reconcile. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

Implements in the TaskRun controller the logic to provide the cloud event pipeline resource. This commits puts together the API, cloud event helper and resource definition from four pull requests: - #1090 - #1091 - #1092 It adds unit tests for the new code and one E2E YAML test. The YAML test runs a simple http server that can receive the cloudevent for test purposes. The list of cloud events to be sent is added to the TaskRun status and processed by the TaskRun controller once the pod associated to the TaskRun completes its execution. The `isDone` definition of the TaskRun is not altered, the reconciler checks for events to be sent once the TaskRun.isDone is true. Retries are not implemented yet in the sense that every scheduled event will be attempted exactly once, but it may be that those attempts happen across different invocations of Reconcile. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

tekton-robot requested review from dlorenc and vdemeester July 16, 2019 18:25

googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 16, 2019

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2019

afrittoli mentioned this pull request Jul 16, 2019

Cloud Event output resource #837

Merged

3 tasks

afrittoli force-pushed the cloud_event_types_spec branch from ed5eb0b to 8d4ccc3 Compare July 16, 2019 19:10

Define new types for Cloud Events

fec3ab5

Define new types in TaskRun to hold the information and status about cloud events to be delivered once a TaskRun is complete. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

afrittoli force-pushed the cloud_event_types_spec branch from 8d4ccc3 to fec3ab5 Compare July 16, 2019 20:15

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019

tekton-robot assigned dlorenc Jul 22, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019

vdemeester reviewed Jul 22, 2019

View reviewed changes

tekton-robot merged commit 17a6a87 into tektoncd:master Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define new types for Cloud Events #1092

Define new types for Cloud Events #1092

afrittoli commented Jul 16, 2019 •

edited

Loading

tekton-robot commented Jul 16, 2019

tekton-robot commented Jul 16, 2019

dlorenc commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

dlorenc commented Jul 22, 2019

vdemeester left a comment

afrittoli commented Jul 22, 2019

vdemeester commented Jul 22, 2019

Define new types for Cloud Events #1092

Define new types for Cloud Events #1092

Conversation

afrittoli commented Jul 16, 2019 • edited Loading

Changes

Submitter Checklist

tekton-robot commented Jul 16, 2019

tekton-robot commented Jul 16, 2019

dlorenc commented Jul 22, 2019

tekton-robot commented Jul 22, 2019

dlorenc commented Jul 22, 2019

vdemeester left a comment

Choose a reason for hiding this comment

afrittoli commented Jul 22, 2019

vdemeester commented Jul 22, 2019

afrittoli commented Jul 16, 2019 •

edited

Loading