Adds container name to taskrun.status.steps #1100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recently while introducing some minor changes in steps status details, it broked some
functionality across CLI, Dashboard and other projects integration.
Maybe because those integration tries to extract some attributes related to the pod base on
TaskRun.Status fields i.e extracting the container name from step's name for
fetching the logs for TaskRun.Status.Steps.
In order to fix the issue, this patch adds container name in step's status. So that
consumer of status API dont need figure internal details based on steps details.
Fixes #1027
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task and TaskRun to build and release this image
Release Notes