Vendor and build gcs-fetcher image in release #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
approved
googlebot
added
the
cla: yes
tekton-robot
added
size/S
|
/test pull-tekton-pipeline-integration-tests |
|
/lgtm |
|
(also testing my prow update.... 😅 ) |
|
/test pull-tekton-pipeline-unit-tests |
|
Wait can I only re-run failed stuff? I don't even know how this works.... |
|
/test all |
tekton-robot
added
size/M
|
/lgtm |
|
tekton-robot
added
size/XXL
|
/test pull-tekton-pipeline-integration-tests |
imjasonh
force-pushed
the
gcs-fetcher
branch
2 times, most recently
from
4143725
to
7eb873b
Compare
tekton-robot
removed
the
size/XXL
tekton-robot
added
the
size/S
tekton-robot
added
size/XXL
bobcatfish
reviewed
Aug 13, 2019
config/controller.yaml
Outdated
| @@ -41,6 +41,8 @@ spec: | |||
| "-entrypoint-image", "github.com/tektoncd/pipeline/cmd/entrypoint", | |||
| "-imagedigest-exporter-image", "github.com/tektoncd/pipeline/cmd/imagedigestexporter", | |||
| "-pr-image", "github.com/tektoncd/pipeline/cmd/pullrequest-init", | |||
| "-build-gcs-fetcher-image", "github.com/tektoncd/pipeline/vendor/github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher/cmd/gcs-fetcher", | |||
| "-build-gcs-uploader-image", "github.com/tektoncd/pipeline/vendor/github.com/GoogleCloudPlatform/cloud-builders/gcs-fetcher/cmd/gcs-uploader", | |||
There was a problem hiding this comment.
I think there's an indentation inconsistency?
|
/lgtm |
|
/hold |
tekton-robot
added
the
do-not-merge/hold
This changes the default value of the gcs-build resource image to an image vendored into the pipelines repo and built during release (or ko apply for local development). This gives us more control over the version used by users, since the image will be built by us from vendored/versioned source.
|
/hold cancel Spacing issue is resolved. |
tekton-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dibyom
added a commit
to dibyom/pipeline
that referenced
this pull request
Aug 14, 2019
These two images were added in tektoncd#1159 and the release task and pipeline have to be updated for a release to be successful. Also, fixes a typo in the pull request resource image name. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
1 task
dibyom
added a commit
to dibyom/pipeline
that referenced
this pull request
Aug 14, 2019
These two images were added in tektoncd#1159 and the release task and pipeline have to be updated for a release to be successful. Also, fixes a typo in the pull request resource image name. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
pushed a commit
that referenced
this pull request
Aug 14, 2019
These two images were added in #1159 and the release task and pipeline have to be updated for a release to be successful. Also, fixes a typo in the pull request resource image name. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default value of the gcs-build resource image to an
image vendored into the pipelines repo and built during release (or ko
apply for local development).
This gives us more control over the version used by users, since the
image will be built by us from vendored/versioned source.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task and TaskRun to build and release this image
I think this doesn't apply to this PR, but someone who knows more should probably double-check.
Release Notes