Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few comments #1207

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Fix a few comments #1207

merged 1 commit into from
Aug 16, 2019

Conversation

afrittoli
Copy link
Member

As a follow-up to the review comments on
#837, fix a few comments
in the code.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

Release Notes

N/A

@afrittoli
Fix a few comments
147ac27 
As a follow-up to the review comments on
tektoncd#837, fix a few comments
in the code.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Aug 16, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2019
bobcatfish
bobcatfish reviewed Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afrittoli !

/lgtm

pkg/reconciler/v1alpha1/taskrun/resources/cloudevent/cloud_event_controller.go
@@ -28,7 +28,7 @@ import (
// InitializeCloudEvents initializes the CloudEvents part of the
// TaskRunStatus from a slice of PipelineResources
func InitializeCloudEvents(tr *v1alpha1.TaskRun, prs []*v1alpha1.PipelineResource) {
// FIXME(afrittoli) If there are no events this is run every time
// If there are no cloud event resources, this check will run on every reconcile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :D

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@bobcatfish
Copy link
Collaborator 

init_test.go:113: Create namespace arendelle-mf52m to deploy to
init_test.go:125: Verify SA "default" is created in namespace "arendelle-mf52m"
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-0".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-1".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-2".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-3".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-4".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-5".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-6".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-7".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-8".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-9".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-10".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-11".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-12".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-13".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-14".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-15".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-16".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-17".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-18".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-19".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-20".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-21".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-22".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-23".
duplicate_test.go:44: Creating taskrun "duplicate-pod-taskrun-24".
duplicate_test.go:53: Error creating taskrun: etcdserver: request timed out, possibly due to previous leader failure
artifact_bucket_test.go:56: ############################################

👀

@bobcatfish
Copy link
Collaborator

/test pull-tekton-pipeline-integration-tests

1 similar comment
@bobcatfish
Copy link
Collaborator

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 6089c9a into tektoncd:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afrittoli @tekton-robot @bobcatfish @googlebot