Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v0.6.0 docs to include fixed tutorial 🤒 #1208

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

bobcatfish
Copy link
Collaborator

Changes

In #1199 @moficodes reported that the tutorial wasn't working which was
b/c in #1172 when I updated the braces, I only half updated the tutorial
example. I wanted to fix this for the v0.6.0 docs as well, but since the
released binary and yaml files don't need an update, it didn't make
sense to me to create v0.6.1 for this (and leave the v0.6.0 docs
broken!) so I created a 0.6 branch and cherry picked the docs fix into
it only, and am now updating the README to point at that.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

In tektoncd#1199 @moficodes reported that the tutorial wasn't working which was
b/c in tektoncd#1172 when I updated the braces, I only half updated the tutorial
example. I wanted to fix this for the v0.6.0 docs as well, but since the
released binary and yaml files don't need an update, it didn't make
sense to me to create v0.6.1 for this (and leave the v0.6.0 docs
broken!) so I created a 0.6 branch and cherry picked the docs fix into
it only, and am now updating the README to point at that.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Aug 16, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2019
@bobcatfish
Copy link
Collaborator Author

bobcatfish commented Aug 16, 2019

Heads up @vdemeester @imjasonh @afrittoli @dibyom @sbwsg @dlorenc @abayer - so I've created a 0.6 branch but I haven't actually tagged a new release (see description above). Let me know if you think this is too crazy and we should tag a new release after all.

@ghost
Copy link

ghost commented Aug 16, 2019

This makes perfect sense to me. I would suggest that cutting release branches versus just tagging master is, in general, probably a good practice. But that's prolly a whole different convo to have another time.

@ghost
Copy link

ghost commented Aug 16, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Aug 16, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@tekton-robot tekton-robot merged commit 5302972 into tektoncd:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants