Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reconciler package to not reference api version #1216

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

vdemeester
Copy link
Member

Changes

The reconciler package might use support an api version or more, but
should be itseslf under an api version package. Only the types need to be.

/cc @bobcatfish

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

The reconciler package might use support an api version or more, but
should be itseslf under an api version package. Only the types need to be.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Aug 19, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2019
@bobcatfish
Copy link
Collaborator

Makes sense to me!

This is gonna cause a few conflicts for ppl working on stuff right now probably :S heads up @dlorenc @dibyom !!

/lgtm
/meow space

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

Makes sense to me!

This is gonna cause a few conflicts for ppl working on stuff right now probably :S heads up @dlorenc @dibyom !!

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipeline/dag/dag.go Do not exist 97.7%
pkg/reconciler/pipelinerun/cancel.go Do not exist 78.6%
pkg/reconciler/pipelinerun/config/store.go Do not exist 87.5%
pkg/reconciler/pipelinerun/controller.go Do not exist 100.0%
pkg/reconciler/pipelinerun/pipelinerun.go Do not exist 82.4%
pkg/reconciler/pipelinerun/resources/apply.go Do not exist 100.0%
pkg/reconciler/pipelinerun/resources/conditionresolution.go Do not exist 80.0%
pkg/reconciler/pipelinerun/resources/input_output_steps.go Do not exist 95.2%
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go Do not exist 94.5%
pkg/reconciler/pipelinerun/resources/validate_params.go Do not exist 100.0%
pkg/reconciler/taskrun/cancel.go Do not exist 87.5%
pkg/reconciler/taskrun/controller.go Do not exist 100.0%
pkg/reconciler/taskrun/entrypoint/entrypoint.go Do not exist 76.9%
pkg/reconciler/taskrun/resources/apply.go Do not exist 97.6%
pkg/reconciler/taskrun/resources/cloudevent/cloud_event_controller.go Do not exist 100.0%
pkg/reconciler/taskrun/resources/cloudevent/cloudevent.go Do not exist 90.5%
pkg/reconciler/taskrun/resources/cloudevent/cloudeventclient.go Do not exist 11.1%
pkg/reconciler/taskrun/resources/cloudevent/cloudeventsfakeclient.go Do not exist 75.0%
pkg/reconciler/taskrun/resources/image_exporter.go Do not exist 87.8%
pkg/reconciler/taskrun/resources/input_resources.go Do not exist 91.7%
pkg/reconciler/taskrun/resources/output_resource.go Do not exist 91.7%
pkg/reconciler/taskrun/resources/pod.go Do not exist 88.9%
pkg/reconciler/taskrun/resources/taskresourceresolution.go Do not exist 100.0%
pkg/reconciler/taskrun/resources/taskspec.go Do not exist 100.0%
pkg/reconciler/taskrun/resources/volume.go Do not exist 100.0%
pkg/reconciler/taskrun/sidecars/stop.go Do not exist 91.7%
pkg/reconciler/taskrun/taskrun.go Do not exist 69.9%
pkg/reconciler/taskrun/timeout_check.go Do not exist 100.0%
pkg/reconciler/taskrun/validate_resources.go Do not exist 94.7%

@tekton-robot tekton-robot merged commit e2aa335 into tektoncd:master Aug 19, 2019
@vdemeester vdemeester deleted the reconcilier-not-versionned branch August 19, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants