Emit pipelinerun event when it is cancelled

[Letty5411]

Fixes #1229

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task and TaskRun to build and release this image

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tekton-robot]

Hi @Letty5411. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Letty5411]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[Letty5411]

/assign @bobcatfish

[bobcatfish]

Thanks for finding this problem and fixing it this @Letty5411 !

Would you mind adding a test for this as well?

It looks like the best place to add it would be in our cancel tests: https://github.com/tektoncd/pipeline/blob/master/test/cancel_test.go

You can see an example of another end to end test that tests the events in https://github.com/tektoncd/pipeline/blob/master/test/pipelinerun_test.go#L203

[Letty5411]

Thanks for finding this problem and fixing it this @Letty5411 !

Would you mind adding a test for this as well?

It looks like the best place to add it would be in our cancel tests: https://github.com/tektoncd/pipeline/blob/master/test/cancel_test.go

You can see an example of another end to end test that tests the events in https://github.com/tektoncd/pipeline/blob/master/test/pipelinerun_test.go#L203

Thanks for your suggestion, I have added the test.

[dibyom]

/ok-to-test

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	Do not exist	82.5%

[dibyom]

hey @Letty5411 looks like the build test is failing with a lint error:

I0905 22:16:49.542] test/cancel_test.go:190: File is not gofmt-ed with -s (gofmt)

Could you run gofmt -s -w test/cancel_test.go? Otherwise, this change looks good 👍

[Letty5411]

hey @Letty5411 looks like the build test is failing with a lint error:

I0905 22:16:49.542] test/cancel_test.go:190: File is not gofmt-ed with -s (gofmt)

Could you run gofmt -s -w test/cancel_test.go? Otherwise, this change looks good 👍

Thanks for your review, I have fixed it.

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	82.1%	82.4%	0.3

[Letty5411]

hi @dibyom , if this PR is OK, could you help merge it, thanks~

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, Letty5411

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

Thank you for your PR and fix!
The change looks good to me.

[afrittoli]

/lgtm

[afrittoli]

/test pull-tekton-pipeline-integration-tests