-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1238
fix #1238
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MemorySpring The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @MemorySpring. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix - as I read through this doc (I hadn't seen this before) I noticed a few additional errors. Would you mind addressing these as well?
Line 17: know_hosts
should be known_hosts
Line 20: known hosts
should be known_hosts
Line 146: -dokcer-cfg
should be -docker-cfg
Could you also please amend your commit message to be more descriptive? If it says something like "Minor documentation improvements", that helps with release notes and git log --oneline
investigations.
/ok-to-test |
/hold @MemorySpring can you take @ahpook comments into account, sign the cla and also update your PR title and you commit title and description ? ( |
Quick patch to address documentation errors. Thanks @MemorySpring for the initial change, I'm just carrying this forward. This closes and supercedes tektoncd#1238
Closing in favor of #1297, thanks @MemorySpring 🤗 /close |
@vdemeester: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quick patch to address documentation errors. Thanks @MemorySpring for the initial change, I'm just carrying this forward. This closes and supercedes #1238
Changes
Creds-init/Readme.md has some wrong informations
~/.ssh/known_hosts with the content of ssh-privatekey decoded
should be
~/.ssh/known_hosts with the content of known_hosts decoded
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task and TaskRun to build and release this image
Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.
Release Notes