Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1238

Closed
wants to merge 1 commit into from
Closed

fix #1238

wants to merge 1 commit into from

Conversation

MemorySpring
Copy link

Changes

Creds-init/Readme.md has some wrong informations

~/.ssh/known_hosts with the content of ssh-privatekey decoded
should be
~/.ssh/known_hosts with the content of known_hosts decoded

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MemorySpring
To complete the pull request process, please assign imjasonh
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2019
@tekton-robot
Copy link
Collaborator

Hi @MemorySpring. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix - as I read through this doc (I hadn't seen this before) I noticed a few additional errors. Would you mind addressing these as well?

Line 17: know_hosts should be known_hosts
Line 20: known hosts should be known_hosts
Line 146: -dokcer-cfg should be -docker-cfg

Could you also please amend your commit message to be more descriptive? If it says something like "Minor documentation improvements", that helps with release notes and git log --oneline investigations.

@imjasonh
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2019
@vdemeester
Copy link
Member

/hold

@MemorySpring can you take @ahpook comments into account, sign the cla and also update your PR title and you commit title and description ? (fix doesn't really comply with our guidelines)

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
ahpook pushed a commit to ahpook/pipeline that referenced this pull request Sep 10, 2019
Quick patch to address documentation errors.

Thanks @MemorySpring for the initial change, I'm just carrying this forward.

This closes and supercedes tektoncd#1238
@vdemeester
Copy link
Member

Closing in favor of #1297, thanks @MemorySpring 🤗

/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closed this PR.

In response to this:

Closing in favor of #1297, thanks @MemorySpring 🤗

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot pushed a commit that referenced this pull request Sep 11, 2019
Quick patch to address documentation errors.

Thanks @MemorySpring for the initial change, I'm just carrying this forward.

This closes and supercedes #1238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants