Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed-by label to Pods created from TaskRuns #1329

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

imjasonh
Copy link
Member

Changes

Also annotate the controllers' Deployments and created Pods with labels
denoting their purpose.

This is a Kubernetes best practice
(https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/)
and will allow operators to understand at a high level where these Pods
come from.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Label Pods created to run TaskRuns with `managed-by` to denote Tekton created them.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Sep 18, 2019
@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2019
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/pod.go 89.0% 89.7% 0.8

Also annotate the controllers' Deployments and created Pods with labels
denoting their purpose.

This is a Kubernetes best practice
(https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/)
and will allow operators to understand at a high level where these Pods
come from.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/pod.go 89.0% 89.7% 0.8

@ghost
Copy link

ghost commented Sep 18, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Sep 18, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@tekton-robot tekton-robot merged commit eb6edee into tektoncd:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants