Remove deprecated serviceAccount field from *Run 🌳

[vdemeester]

Changes

This removes the deprecated serviceAccount field from TaskRun and
PipelineRun in favor of the newly added serviceAccountName (in
previous release) to match more closely the kubernetes API.

Closes #1219

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/cc @bobcatfish @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Remove deprecated serviceAccount field from TaskRun/PipelineRun in favor of serviceAccountName

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	97.1%	96.6%	-0.5
pkg/apis/pipeline/v1alpha1/taskrun_types.go	77.4%	74.1%	-3.3
test/builder/pipeline.go	84.2%	87.3%	3.1
test/builder/task.go	80.2%	81.4%	1.2

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	97.1%	96.6%	-0.5
pkg/apis/pipeline/v1alpha1/taskrun_types.go	77.4%	74.1%	-3.3
test/builder/pipeline.go	84.2%	87.3%	3.1
test/builder/task.go	80.2%	81.4%	1.2

[afrittoli]

@vdemeester rebase? 👼

[afrittoli]

Nice work, thank you!

/lgtm

[vdemeester]

oh boy.. I need to rebase indeed 😂

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	97.1%	96.6%	-0.5
pkg/apis/pipeline/v1alpha1/taskrun_types.go	77.4%	74.1%	-3.3
test/builder/pipeline.go	84.2%	87.3%	3.1
test/builder/task.go	80.2%	81.4%	1.2

[ghost]

/lgtm

[afrittoli]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

woot thanks @vdemeester !!