-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Pipeline Resources to be marked as Optional #1910
Enabling Pipeline Resources to be marked as Optional #1910
Conversation
5fb1297
to
5bfa6b7
Compare
/test pull-tekton-pipeline-integration-tests |
1 similar comment
/test pull-tekton-pipeline-integration-tests |
5bfa6b7
to
bfecdca
Compare
/kind feature |
bfecdca
to
d447219
Compare
Pipeline inputs and outputs are considered required, there is no way today to mark them optional. This change introduces a new field called optional as part of the PipelineDeclaredResource similar to previous PR tektoncd#1601, by default optional is set to false and a resource is required. To mark any resource optional, set optional to true: apiVersion: tekton.dev/v1alpha1 kind: Pipeline metadata: name: pipeline-build-image spec: resources: - name: workspace type: git optional: true tasks: - name: check-workspace Closes tektoncd#1710
d447219
to
d63abc6
Compare
/lgtm |
I was trying to figure out what would happen if a pipeline makes a resource optional but a task in the pipeline requires the resource. Would this manifest as a TaskRun error & fail the pipeline? |
Hey @sbwsg it will fail with |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Pipeline inputs and outputs are considered required, there is no way
today to mark them optional. This change introduces a new field called
optional as part of the PipelineDeclaredResource similar to previous PR #1601,
by default optional is set to false and a resource is required.
To mark any resource optional, set optional to true:
Closes #1710
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Allowing any pipeline resource to be declared as
optional
.