-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove messages about kodata in task logs #2000
Conversation
… use the default Zap sugared logger. Previously, these loggers cluttered Task output with messages about being unable to fetch ko information. This addresses tektoncd#1145
Hi @tomgeorge. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
very cool thanks for fixing this /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this issue!
The kantive logging package gives features like the ability of changing log level at run time - while that is appropriate for the controllers I think we don't really need it for the tasks, so I think this change is nice.
Pipeline resources and entrypoint did not honor the config settings in from the logging configuration map anyways, and this doesn't change that.
What I think would be nice to have - but it's not related to this PR - is some documentation in https://github.com/tektoncd/pipeline/blob/master/docs/install.md#configuring-tekton-pipelines about how to configure logging and what part of Tekton are affected by it.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Change the loggers in entrypoint, creds-init, and pullrequest-init to use the default Zap sugared logger.
Previously, these loggers cluttered Task output with messages about being unable to fetch ko information.
This addresses #1145
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes