Update some more example links and move task results example #2148
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
| - [Task](../examples/v1alpha1/taskruns/optional-resources.yaml) | ||
| - [Cluster Task](../examples/v1alpha1/taskruns/optional-resources-with-clustertask.yaml) | ||
| - [Condition](../examples/v1alpha1/pipelineruns/conditional-pipelinerun-with-optional-resources.yaml) | ||
| - [Pipeline](../examples/v1alpha1/pipelineruns/demo-optional-resources.yaml) |
There was a problem hiding this comment.
Wasn't sure about these. Linking from the pipeline resources doc (pipeline resources are remaining alpha) so decided to point at v1alpha1 examples. Could be convinced otherwise, anyone got thoughts on this?
There was a problem hiding this comment.
/meow
I guess you part of #2139 gets fixed (at least the link)
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
Found a few more links that needed to be updated to point to the new examples directories. Moved the task_results_example.yaml into the v1beta1 directory.
tekton-robot
added
size/L
| - name: a | ||
| value: "2" | ||
| - name: b | ||
| value: "10" |
There was a problem hiding this comment.
follow up idea: would be neat to add an "expected-output" param that checks whether the final result is the expected number.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-tekton-pipeline-integration-tests |
|
That test run looks stuck to me. |
ghost
mentioned this pull request
Changes
Found a few more links that needed to be updated to point to the new
examples directories.
Moved the task_results_example.yaml into the v1beta1 directory and updated it to include a PipelineRun so that the results are exercised.
See #2145 and #2147 for similar changes.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.