Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes in our doc #2206

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Spelling fixes in our doc #2206

merged 1 commit into from
Mar 10, 2020

Conversation

skaegi
Copy link
Contributor

@skaegi skaegi commented Mar 10, 2020

Found using mdspell -a -n --en-us "**/*.md". At some point we might want to have a built in ignore dictionary to avoid false positives.

Changes

Just minor spelling fixes (I assumed en-us spelling for consistency)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Found using `mdspell -a -n --en-us "**/*.md"`. At some point we might want to have a built in ignore dictionary to avoid false positives.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 10, 2020
@tekton-robot tekton-robot requested review from dlorenc and a user March 10, 2020 18:04
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2020
@ghost
Copy link

ghost commented Mar 10, 2020

I take offence at this behaviour.

/approve
/lgtm

@tekton-robot tekton-robot assigned ghost Mar 10, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@ghost ghost added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 10, 2020
@ghost
Copy link

ghost commented Mar 10, 2020

/test pull-tekton-pipeline-build-tests

@skaegi
Copy link
Contributor Author

skaegi commented Mar 10, 2020

/retest

@skaegi
Copy link
Contributor Author

skaegi commented Mar 10, 2020

It's behaviour up here in the north too but... must be consistent. ;)

@tekton-robot tekton-robot merged commit 7b87070 into tektoncd:master Mar 10, 2020
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants