Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of pipeline results #2690

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Improve performance of pipeline results #2690

merged 1 commit into from
Jun 6, 2020

Conversation

othomann
Copy link
Contributor

Changes

Improve performance of pipeline results by using the pipeline status.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

1 similar comment
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@othomann othomann mentioned this pull request May 25, 2020
Closed
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.3% 80.9% 5.7
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 87.5% 87.8% 0.3

@othomann
Copy link
Contributor Author

othomann commented May 26, 2020 •
edited
Loading

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 26, 2020
@othomann
Copy link
Contributor Author

@afrittoli Hi, would it be possible for you to review this PR? Thank you.

@afrittoli
Copy link
Member

@afrittoli Hi, would it be possible for you to review this PR? Thank you.

Hi, thanks for this PR. Sure, it's already on my todo list :)

afrittoli
afrittoli reviewed May 29, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
I've not managed to finish my review, I'll continue on Monday.
At a high level it looks good, the only concern I have it's with the missing error condition on failed spec.

pkg/reconciler/pipelinerun/pipelinerun.go Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.3% 79.8% 4.6
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 87.5% 87.8% 0.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.3% 79.8% 4.6
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 87.5% 87.8% 0.3

afrittoli
afrittoli reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

This is basically changing the updatePipelineResults so that it works based on the pipeline run status instead of the pipeline run state. Building the pipeline run state requires fetching the spec again and re-running validation. This patch also reduces code duplication.

Performance-wise, after seeing #2740, I think that solving that might will provide the most part of the performance improvement; nonetheless I think having this still make sense, as even if fetching the spec is done from the informer, we still need to run validation.

@vdemeester @imjasonh @bobcatfish

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
This was referenced Jun 4, 2020
Closed
Closed
vdemeester
vdemeester reviewed Jun 4, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vdemeester
Copy link
Member

@othomann needs a rebase though 😅

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@othomann
Copy link
Contributor Author

othomann commented Jun 4, 2020

I just rebase. Hopefully this is ok now with the tests.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 80.2% 81.5% 1.3
pkg/reconciler/pipelinerun/resources/resultrefresolution.go 87.5% 87.8% 0.3

@othomann
Copy link
Contributor Author

othomann commented Jun 4, 2020

@afrittoli @vdemeester should be all good. I rebased today. Thanks.

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
afrittoli
afrittoli reviewed Jun 6, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2020
@tekton-robot tekton-robot merged commit 194102f into tektoncd:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester left review comments

@dibyom dibyom Awaiting requested review from dibyom

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@othomann @tekton-robot @afrittoli @vdemeester