Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various reconciler cleanups #2784

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Various reconciler cleanups #2784

merged 2 commits into from
Jun 10, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Jun 8, 2020

Changes

/kind cleanup

This cleans up reconciler.Base, most of which is defunct now thanks to the // +genreconciler framework. As part of this, some fields are inlined into the FooRun reconcilers, and others (e.g. logger, recorder) are picked up off of the context.

Depends on #2771

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 8, 2020
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 8, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/affinity_assistant.go 91.5% 91.7% 0.2
pkg/reconciler/pipelinerun/pipelinerun.go 81.7% 82.1% 0.3
pkg/reconciler/taskrun/taskrun.go 75.5% 77.7% 2.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/affinity_assistant.go 91.5% 91.7% 0.2
pkg/reconciler/pipelinerun/pipelinerun.go 81.7% 82.1% 0.3
pkg/reconciler/taskrun/taskrun.go 75.5% 77.7% 2.2

@mattmoor
Usage logger from context
68caa7f
@mattmoor
Drop reconciler.Base and other cleanup
0bebbf1 
This cleans up a number of things now that we are on `// +genreconciler`.
@mattmoor mattmoor changed the title [WIP] Various reconciler cleanups Various reconciler cleanups Jun 9, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 9, 2020

/assign @vdemeester @afrittoli @imjasonh

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/affinity_assistant.go 91.5% 91.7% 0.2
pkg/reconciler/pipelinerun/pipelinerun.go 81.7% 82.1% 0.3
pkg/reconciler/taskrun/controller.go 96.7% 96.6% -0.1
pkg/reconciler/taskrun/taskrun.go 77.0% 77.7% 0.7

vdemeester
vdemeester reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
😻

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2020
afrittoli
afrittoli reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@tekton-robot tekton-robot merged commit 64678e3 into tektoncd:master Jun 10, 2020
bobcatfish
bobcatfish reviewed Jun 24, 2020
View reviewed changes
pkg/reconciler/pipelinerun/affinity_assistant.go
@@ -61,7 +64,7 @@ func (c *Reconciler) createAffinityAssistants(wb []v1alpha1.WorkspaceBinding, pr
errs = append(errs, fmt.Errorf("failed to create StatefulSet %s: %s", affinityAssistantName, err))
}
if err == nil {
c.Logger.Infof("Created StatefulSet %s in namespace %s", affinityAssistantName, namespace)
logger.Infof("Created StatefulSet %s in namespace %s", affinityAssistantName, namespace)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mattmoor does this mean the reconciler no longer has a logger object or just that we shouldn't use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@bobcatfish bobcatfish bobcatfish left review comments

@vdemeester vdemeester vdemeester left review comments

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @tekton-robot @vdemeester @bobcatfish @afrittoli @imjasonh