-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup logic for API convertion errors #2818
Cleanup logic for API convertion errors #2818
Conversation
When we used to store v1alpha1, the get pipeline and task data function could return an error related to coverting between API versions. Now that we store v1beta1, that error is not returned anymore by those functions, so we can cleanup the error handling specific to it.
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR cannot be merged: expecting exactly one kind/ label Available
|
Changes
When we used to store v1alpha1, the get pipeline and task data
function could return an error related to coverting between
API versions. Now that we store v1beta1, that error is not
returned anymore by those functions, so we can cleanup the
error handling specific to it.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
/kind cleanup