-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bumping catalog dependency to process of creating a release #2833
Add bumping catalog dependency to process of creating a release #2833
Conversation
Eventually we want to be able to have Tasks declare what versions they are compatible with and test against those (tektoncd/catalog#373) but in the meantime, it seems reasonable to bump the version used in catalog tests every time we do a release (and even once we have tektoncd/catalog#373, we would want to be running tests against new versions as well - and this could have the benefit of giving us information about issues in a release early, before users notice them!) Question: how does the person making the release ensure that this bump didn't make anything start failing? I think we should still make this part of the process before we figure this out entirely, but we might want to create a cron or something that runs all the tests nightly, and maybe have the build cop trigger the release manually to ensure there aren't any problems?
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
This PR cannot be merged: expecting exactly one kind/ label Available
|
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long-term this shouldn't be necessary as the catalog will most likely run tests against multiple version of tekton. But for the time being 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ohhhhhh this must be because of tektoncd/plumbing#430 🤔 i wonder if we should be more careful about these kinds of bumps, e.g. try them out first. that would be tough b/c it might be doing stuff like this in other repos too. |
/test pull-tekton-pipeline-build-tests |
/lgtm |
Changes
Eventually we want to be able to have Tasks declare what versions they
are compatible with and test against those
(tektoncd/catalog#373) but in the meantime, it
seems reasonable to bump the version used in catalog tests every time we
do a release (and even once we have tektoncd/catalog#373,
we would want to be running tests against new versions as well - and this
could have the benefit of giving us information about issues in a release
early, before users notice them!)
Question: how does the person making the release ensure that this bump
didn't make anything start failing? I think we should still make this
part of the process before we figure this out entirely, but we might
want to create a cron or something that runs all the tests nightly, and
maybe have the build cop trigger the release manually to ensure there
aren't any problems?
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.