Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bumping catalog dependency to process of creating a release #2833

Merged

Conversation

bobcatfish
Copy link
Collaborator

Changes

Eventually we want to be able to have Tasks declare what versions they
are compatible with and test against those
(tektoncd/catalog#373) but in the meantime, it
seems reasonable to bump the version used in catalog tests every time we
do a release (and even once we have tektoncd/catalog#373,
we would want to be running tests against new versions as well - and this
could have the benefit of giving us information about issues in a release
early, before users notice them!)

Question: how does the person making the release ensure that this bump
didn't make anything start failing? I think we should still make this
part of the process before we figure this out entirely, but we might
want to create a cron or something that runs all the tests nightly, and
maybe have the build cop trigger the release manually to ensure there
aren't any problems?

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Eventually we want to be able to have Tasks declare what versions they
are compatible with and test against those
(tektoncd/catalog#373) but in the meantime, it
seems reasonable to bump the version used in catalog tests every time we
do a release (and even once we have tektoncd/catalog#373,
we would want to be running tests against new versions as well - and this
could have the benefit of giving us information about issues in a release
early, before users notice them!)

Question: how does the person making the release ensure that this bump
didn't make anything start failing? I think we should still make this
part of the process before we figure this out entirely, but we might
want to create a cron or something that runs all the tests nightly, and
maybe have the build cop trigger the release manually to ensure there
aren't any problems?
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2020
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

1 similar comment
@tekton-robot
Copy link
Collaborator

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

@vdemeester
Copy link
Member

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 18, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term this shouldn't be necessary as the catalog will most likely run tests against multiple version of tekton. But for the time being 👍

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@bobcatfish
Copy link
Collaborator Author

				if err := updateStatusStartTime(&s); err != nil {
				                                ^
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go:237:46: G601: Implicit memory aliasing in for loop. (gosec)
		r, err := resources.GetResourceFromBinding(&resource, getResource)
		                                           ^

ohhhhhh this must be because of tektoncd/plumbing#430 🤔 i wonder if we should be more careful about these kinds of bumps, e.g. try them out first. that would be tough b/c it might be doing stuff like this in other repos too.

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-build-tests

@dlorenc
Copy link
Contributor

dlorenc commented Jun 23, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@tekton-robot tekton-robot merged commit 7575000 into tektoncd:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants