Activate SA creds before running ko #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
Replaces `CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE` with an explicit call to `gcloud auth activate-service-account`. `gcloud info --run-diagnostics` pointed to this potentially being the issue causing the nightly build failures. In addition, I also removed the verbose option from the command that tars up the vendor directory. This reduces the log by ~6000 lines! Tested on the dogfooding cluster with a manual run: `pipeline-release-nightly-dx7cq` Fixes tektoncd#2838 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
vdemeester
reviewed
Jun 23, 2020
afrittoli
reviewed
Jun 23, 2020
| # Activate service account | ||
| gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS} | ||
|
|
||
| # Setup docker-auth | ||
| gcloud auth configure-docker |
There was a problem hiding this comment.
NIT: we might want to add --quiet here so that it doesn't prompt for confirmation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
dibyom
added a commit
to dibyom/triggers
that referenced
this pull request
Jun 24, 2020
This commit includes two fixes: 1. Replaces `CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE` with an explicit call to `gcloud auth activate-service-account`. This is the same fix as tektoncd/pipeline#2847. 2. Pass images with tags to ko_parse.py to validate the images. This bug was introduced in tektoncd#598 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
3 tasks
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
Jun 24, 2020
This commit includes two fixes: 1. Replaces `CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE` with an explicit call to `gcloud auth activate-service-account`. This is the same fix as tektoncd/pipeline#2847. 2. Pass images with tags to ko_parse.py to validate the images. This bug was introduced in #598 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
dibyom
added a commit
to dibyom/dashboard
that referenced
this pull request
Jun 30, 2020
The dashboard nightly has failed 2 out of the last 3 runs due to the same credentials related issue that was affecting the pipeline and triggers releases (see tektoncd/pipeline#2838). This commit fixes the build by replacing the problematic environment variable with an explicit call to activate the service account (just like tektoncd/pipeline#2847). Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
3 tasks
tekton-robot
pushed a commit
to tektoncd/dashboard
that referenced
this pull request
Jul 1, 2020
The dashboard nightly has failed 2 out of the last 3 runs due to the same credentials related issue that was affecting the pipeline and triggers releases (see tektoncd/pipeline#2838). This commit fixes the build by replacing the problematic environment variable with an explicit call to activate the service account (just like tektoncd/pipeline#2847). Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces
CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDEwith an explicit callto
gcloud auth activate-service-account.gcloud info --run-diagnosticspointed to this potentially being the issue causingthe nightly build failures.
In addition, I also removed the verbose option from the command that
tars up the vendor directory. This reduces the log by ~6000 lines!
Tested on the dogfooding cluster with a manual run:
pipeline-release-nightly-dx7cqFixes #2838
Signed-off-by: Dibyo Mukherjee dibyo@google.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
/kind bug