Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to replace image names for examples tests based on arch #3299

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add ability to replace image names for examples tests based on arch #3299

merged 1 commit into from
Oct 6, 2020

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Sep 29, 2020 •
edited
Loading

Changes

Some images which are used to run the examples tests are amd64 only.
To run the examples tests for other architectures it makes sense to replace the
amd64 image names to arch-specific ones at runtime.

  • add code to search and replace image names based on architecture in the
    examples yaml files at runtime.
  • provide mapping between amd64 and s390x image names.
  • remove several tests from excluded list for s390x.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 29, 2020
@tekton-robot tekton-robot requested review from imjasonh and a user September 29, 2020 11:59
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2020
@tekton-robot
Copy link
Collaborator

Hi @barthy1. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@ghost
Copy link

ghost commented Sep 29, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2020
@ghost
Copy link

ghost commented Sep 29, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 29, 2020
imjasonh
imjasonh reviewed Sep 29, 2020
View reviewed changes
test/multiarch_utils.go Outdated Show resolved Hide resolved
test/multiarch_utils.go Outdated Show resolved Hide resolved
test/examples_test.go Show resolved Hide resolved
test/examples_test.go Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 29, 2020

Thanks @barthy1 ! You'll need to also add a release-note section at the bottom of your PR description that looks like this:

```release-note
NONE
```

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 29, 2020
@barthy1
Add ability to replace image names for examples tests based on arch
10f4e32 
Some images which are used to run the examples tests are amd64 only.
To run the examples tests for other architectures it makes sense to replace the
amd64 image names to arch-specific ones at runtime.

- add code to search and replace image names based on architecture in the
examples yaml files at runtime.
- provide mapping between amd64 and s390x image names.
- remove several tests from excluded list for s390x.

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@barthy1 barthy1 mentioned this pull request Sep 30, 2020
Merged
@barthy1
Copy link
Member Author

barthy1 commented Sep 30, 2020

/retest

@barthy1
Copy link
Member Author

barthy1 commented Oct 6, 2020

@imjasonh do you have other suggestions for this PR or you are ok with the current state?

imjasonh
imjasonh reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@barthy1
Copy link
Member Author

barthy1 commented Oct 6, 2020

/retest

@tekton-robot tekton-robot merged commit f257b88 into tektoncd:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@vdemeester vdemeester vdemeester left review comments

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barthy1 @tekton-robot @vdemeester @imjasonh