Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update submodules with --init flag #3321

Merged
merged 1 commit into from
Oct 26, 2020
Merged

update submodules with --init flag #3321

merged 1 commit into from
Oct 26, 2020

Conversation

ibotty
Copy link
Contributor

@ibotty ibotty commented Oct 2, 2020

fixes #3320

Changes

This updates pkg/git's submodule updating to also git submodule init recursively. This fixes #3320.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)

I don't know how to write the test. ATM it does not test anything like that. I am a novice in go though.

  • Includes docs (if user facing)

not applicable.

Reviewer Notes

There are no API changes.

Release Notes

Git-init can now clone recursive submodules.

@ibotty
update submodules with --init flag
b30f035 
This updates `pkg/git`'s submodule updating to also `git submodule init` recursively.
Before submodules were not cloned recursively.

Fixes tektoncd#3320
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 2, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 2, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2020
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2020
@tekton-robot
Copy link
Collaborator

Hi @ibotty. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link

ghost commented Oct 2, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 2, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/git/git.go 2.4% 2.5% 0.0

@jerop
Copy link
Member

jerop commented Oct 5, 2020

/remove-kind feature

@tekton-robot tekton-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Oct 5, 2020
@jerop
Copy link
Member

jerop commented Oct 5, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 5, 2020
@ibotty
Copy link
Contributor Author

ibotty commented Oct 26, 2020

Can someone please review?

vdemeester
vdemeester approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @sbwsg

@tekton-robot tekton-robot requested a review from a user October 26, 2020 09:17
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@ghost
Copy link

ghost commented Oct 26, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 26, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@tekton-robot tekton-robot merged commit 43e307f into tektoncd:master Oct 26, 2020
@ibotty
Copy link
Contributor Author

ibotty commented Oct 26, 2020

Thank you!

@ibotty ibotty deleted the fix-recurse-submodules branch October 26, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

git-init does not recurse submodules correctly
4 participants
@ibotty @tekton-robot @jerop @vdemeester