Init conformance test #3400
Merged
Init conformance test #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/release-note-label-needed
tekton-robot
added
the
size/L
imjasonh
reviewed
Oct 16, 2020
|
/kind feature |
tekton-robot
added
the
kind/feature
yaoxiaoqi
force-pushed
the
conformance-test
branch
from
374d8f6
to
3fdd22c
Compare
tekton-robot
added
release-note-none
imjasonh
reviewed
Oct 19, 2020
ghost
approved these changes
Oct 20, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This conformance test checks the required fields of a succeeded TaskRun created by Tekton Pipelines API.
yaoxiaoqi
force-pushed
the
conformance-test
branch
from
3e47765
to
71c083d
Compare
tekton-robot
added
release-note
|
/test pull-tekton-pipeline-integration-tests |
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Apr 1, 2021
In tektoncd#3400 we added an initial conformance test, and added a build tag `conformance` to make it so that folks could run just conformance tests if they wanted to. From what I can see it doesn't look like we use this tag at all in our automation, so I want to add it to the tags we use to run our end to end test to make sure this continues working over time. In the long run I think we might want to explore a couple other alternatives for implementing conformance tests, e.g. including making use of our example tests (though those dont express the desired end state), maybe a tool like [kuttl](https://github.com/kudobuilder/kuttl#kuttl) which @chhsia0 has mentioned in preivous working groups, or like the approach that knative seems to be taking via https://github.com/knative-sandbox/reconciler-test But in the short run let's at least make sure this test keeps working :D Also renamed the test to make it a bit more clear what this test is for in case it fails.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Initialize the conformance test
This conformance test checks the required fields of a succeeded TaskRun created by Tekton Pipelines API.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes