Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add a PipelineRun ServiceAccounts test 🍊 #3420

Merged
merged 1 commit into from
Oct 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 204 additions & 0 deletions test/serviceaccount_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,204 @@
// +build e2e

/*
Copyright 2019 The Tekton Authors

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package test

import (
"context"
"fmt"
"testing"

"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
knativetest "knative.dev/pkg/test"
)

func TestPipelineRunWithServiceAccounts(t *testing.T) {
ctx := context.Background()
ctx, cancel := context.WithCancel(ctx)
defer cancel()

c, namespace := setup(ctx, t)
t.Parallel()

knativetest.CleanupOnInterrupt(func() { tearDown(ctx, t, c, namespace) }, t.Logf)
defer tearDown(ctx, t, c, namespace)

saPerTask := map[string]string{
"task1": "sa1",
"task2": "sa2",
"task3": "sa3",
}

// Create Secrets and Service Accounts
secrets := []corev1.Secret{{
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "secret1",
},
Type: "Opaque",
Data: map[string][]byte{
"foo1": []byte("bar1"),
},
}, {
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "secret2",
},
Type: "Opaque",
Data: map[string][]byte{
"foo2": []byte("bar2"),
},
}, {
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "secret3",
},
Type: "Opaque",
Data: map[string][]byte{
"foo2": []byte("bar3"),
},
}}
serviceAccounts := []corev1.ServiceAccount{{
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "sa1",
},
Secrets: []corev1.ObjectReference{{
Name: "secret1",
}},
}, {
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "sa2",
},
Secrets: []corev1.ObjectReference{{
Name: "secret2",
}},
}, {
ObjectMeta: metav1.ObjectMeta{
Namespace: namespace,
Name: "sa3",
},
Secrets: []corev1.ObjectReference{{
Name: "secret3",
}},
}}
for _, secret := range secrets {
if _, err := c.KubeClient.Kube.CoreV1().Secrets(namespace).Create(ctx, &secret, metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", secret.Name, err)
}
}
for _, serviceAccount := range serviceAccounts {
if _, err := c.KubeClient.Kube.CoreV1().ServiceAccounts(namespace).Create(ctx, &serviceAccount, metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create SA `%s`: %s", serviceAccount.Name, err)
}
}

// Create a Pipeline with multiple tasks
pipeline := &v1beta1.Pipeline{
ObjectMeta: metav1.ObjectMeta{Name: "pipelinewithsas", Namespace: namespace},
Spec: v1beta1.PipelineSpec{
Tasks: []v1beta1.PipelineTask{{
Name: "task1",
TaskSpec: &v1beta1.EmbeddedTask{TaskSpec: v1beta1.TaskSpec{
Steps: []v1beta1.Step{{
Container: corev1.Container{
Image: "ubuntu",
},
Script: `echo task1`,
}},
}},
}, {
Name: "task2",
TaskSpec: &v1beta1.EmbeddedTask{TaskSpec: v1beta1.TaskSpec{
Steps: []v1beta1.Step{{
Container: corev1.Container{
Image: "ubuntu",
},
Script: `echo task2`,
}},
}},
}, {
Name: "task3",
TaskSpec: &v1beta1.EmbeddedTask{TaskSpec: v1beta1.TaskSpec{
Steps: []v1beta1.Step{{
Container: corev1.Container{
Image: "ubuntu",
},
Script: `echo task3`,
}},
}},
}},
},
}
if _, err := c.PipelineClient.Create(ctx, pipeline, metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create Pipeline `%s`: %s", pipeline.Name, err)
}

// Create a PipelineRun that uses those ServiceAccount
pipelineRun := &v1beta1.PipelineRun{
ObjectMeta: metav1.ObjectMeta{Name: "pipelinerunwithasas", Namespace: namespace},
Spec: v1beta1.PipelineRunSpec{
PipelineRef: &v1beta1.PipelineRef{Name: "pipelinewithsas"},
ServiceAccountName: "sa1",
ServiceAccountNames: []v1beta1.PipelineRunSpecServiceAccountName{{
TaskName: "task2", ServiceAccountName: "sa2",
}},
TaskRunSpecs: []v1beta1.PipelineTaskRunSpec{{
PipelineTaskName: "task3", TaskServiceAccountName: "sa3",
}},
},
}

_, err := c.PipelineRunClient.Create(ctx, pipelineRun, metav1.CreateOptions{})
if err != nil {
t.Fatalf("Failed to create PipelineRun `%s`: %s", pipelineRun.Name, err)
}

t.Logf("Waiting for PipelineRun %s in namespace %s to complete", pipelineRun.Name, namespace)
if err := WaitForPipelineRunState(ctx, c, pipelineRun.Name, pipelineRunTimeout, PipelineRunSucceed(pipelineRun.Name), "PipelineRunSuccess"); err != nil {
t.Fatalf("Error waiting for PipelineRun %s to finish: %s", pipelineRun.Name, err)
}

// Verify it used those serviceAccount
taskRuns, err := c.TaskRunClient.List(ctx, metav1.ListOptions{LabelSelector: fmt.Sprintf("tekton.dev/pipelineRun=%s", pipelineRun.Name)})
if err != nil {
t.Fatalf("Error listing TaskRuns for PipelineRun %s: %s", pipelineRun.Name, err)
}
for _, taskRun := range taskRuns.Items {
sa := taskRun.Spec.ServiceAccountName
taskName := taskRun.Labels["tekton.dev/pipelineTask"]
expectedSA := saPerTask[taskName]
if sa != expectedSA {
t.Fatalf("TaskRun %s expected SA %s, got %s", taskRun.Name, expectedSA, sa)
}
pods, err := c.KubeClient.Kube.CoreV1().Pods(namespace).List(ctx, metav1.ListOptions{LabelSelector: fmt.Sprintf("tekton.dev/taskRun=%s", taskRun.Name)})
if err != nil {
t.Fatalf("Error listing Pods for TaskRun %s: %s", taskRun.Name, err)
}
if len(pods.Items) != 1 {
t.Fatalf("TaskRun %s should have only 1 pod association, got %+v", taskRun.Name, pods.Items)
}
podSA := pods.Items[0].Spec.ServiceAccountName
if podSA != expectedSA {
t.Fatalf("TaskRun's pod %s expected SA %s, got %s", pods.Items[0].Name, expectedSA, podSA)
}
}
}