Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix json annotations in WhenExpression #3421

Merged
merged 1 commit into from
Oct 21, 2020

Commits on Oct 21, 2020

  1. Fix json annotations in WhenExpression

    When a pipeline with when expressions is created in v0.16.* then it is
    run in a pipelinerun in v0.17.0 or v0.17.1, a pipeline validation error
    about missing fields would be thrown -- as reported in tektoncd#3382
    
    That happened because json annotations were added to when expressions
    type in v0.17.0 so that the fields would have lowercase, such as in the
    code completion in tekton intellij plugin as described in
    redhat-developer/intellij-tekton#223
    
    Without the json annotations, the fields were stored with first letters
    capitalized, that is Input, Operator and Values. With the json
    annotations, the fields were expected to be lowercase, that is input,
    operator and values, causing the missing fields error in pipeline
    validation
    
    As such, users would have to reapply pipelines definitions created in
    previous versions to make them work in v0.17.0 or v0.17.1 -- to remove
    this requirement, we need to support both the uppercase and lowercase
    first letters for the annotations
    
    Fixes tektoncd#3382
    
    (cherry picked from commit 4edcbc1)
    Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    jerop authored and vdemeester committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    7654ddb View commit details
    Browse the repository at this point in the history