Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make t.Parallel() come first #3425

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

mattmoor
Copy link
Member

Changes

/kind bug

This makes the t.Parallel() call come first in the timeout_test.go tests, where I recently added context.WithTimeout. When t.Parallel() is called, I believe it suspends the test and releases the blocking parent, and -parallel=N instances are allowed to proceed concurrently. I think that in this case, we set up a timeout and then ~immediately suspend our thread!
So when things resume, our context is immediately cancelled 😬

Here's what I'm seeing in my downstream testing (very intermittently):

--- FAIL: TestTaskRunTimeout (1.17s)
    init_test.go:132: Create namespace arendelle-cwq88 to deploy to
    init_test.go:148: Verify SA "default" is created in namespace "arendelle-cwq88"
    timeout_test.go:254: Creating Task and TaskRun in namespace arendelle-cwq88
    timeout_test.go:266: Failed to create Task `giraffe`: context deadline exceeded
    panic.go:636: ############################################
    panic.go:636: ### Dumping objects from arendelle-cwq88 ###
    panic.go:636: ############################################
    panic.go:636: 
    panic.go:636: #####################################################
    panic.go:636: ### Dumping logs from Pods in the arendelle-cwq88 ###
    panic.go:636: #####################################################
--- FAIL: TestStepTimeout (1.09s)
    init_test.go:132: Create namespace arendelle-lnzzk to deploy to
    init_test.go:148: Verify SA "default" is created in namespace "arendelle-lnzzk"
    timeout_test.go:182: Creating Task with Step step-no-timeout, Step step-timeout, and Step step-canceled in namespace arendelle-lnzzk
    timeout_test.go:186: Creating TaskRun run-timeout in namespace arendelle-lnzzk
    timeout_test.go:216: Failed to create TaskRun `run-timeout`: context deadline exceeded
    panic.go:636: ############################################
    panic.go:636: ### Dumping objects from arendelle-lnzzk ###
    panic.go:636: ############################################
    panic.go:636: 
    panic.go:636: #####################################################
    panic.go:636: ### Dumping logs from Pods in the arendelle-lnzzk ###
    panic.go:636: #####################################################

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 21, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2020
@mattmoor
Copy link
Member Author

cc @afrittoli @vdemeester @imjasonh

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@mattmoor
Copy link
Member Author

different test

/retest

@mattmoor
Copy link
Member Author

different test: TaskRunRetry...

/retest

@tekton-robot tekton-robot merged commit ec3ddb5 into tektoncd:master Oct 22, 2020
@mattmoor mattmoor deleted the parallel-first branch October 22, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants